Module: check_mk
Branch: master
Commit: 85386fd44bcaafbd07666f6d2a628bbe2f1dc815
URL:
http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=85386fd44bcaaf…
Author: Jukka Aro <ja(a)mathias-kettner.de>
Date: Tue Mar 27 16:42:34 2018 +0200
Win-agent: extract SectionHeader
This is the first step of splitting the Section class (hierarchy) to
smaller logical entities. The section header forms its own independent
part of section output and has its own parameters that are independent
from the rest of the section.
Define SectionHeader as a separator-character-templated class that is
used as a member variable of Section. Subsection header is implemented
by subclassing the SectionHeader. In order to use the templated
SectionHeader with std::unique_ptr, define a abstract base class
ISectionHeader that all templated SectionHeaders inherit from.
The next steps in splitting Section will be to extract SectionBody to
its own class hierarchy and to provide a factory for instantiating the
sections.
---
agents/windows/Makefile.am | 1 +
agents/windows/SectionManager.cc | 33 +++++--
agents/windows/build_version | 2 +-
agents/windows/sections/Section.cc | 42 ++++-----
agents/windows/sections/Section.h | 20 ++---
agents/windows/sections/SectionCheckMK.cc | 4 +-
agents/windows/sections/SectionDF.cc | 5 +-
agents/windows/sections/SectionDF.h | 1 -
agents/windows/sections/SectionEventlog.cc | 5 +-
agents/windows/sections/SectionFileinfo.cc | 5 +-
agents/windows/sections/SectionFileinfo.h | 2 -
agents/windows/sections/SectionGroup.cc | 27 ++++--
agents/windows/sections/SectionGroup.h | 7 +-
agents/windows/sections/SectionHeader.h | 105 ++++++++++++++++++++++
agents/windows/sections/SectionLogwatch.cc | 9 +-
agents/windows/sections/SectionMRPE.cc | 4 +-
agents/windows/sections/SectionMem.cc | 5 +-
agents/windows/sections/SectionPS.cc | 5 +-
agents/windows/sections/SectionPS.h | 1 -
agents/windows/sections/SectionPerfcounter.cc | 6 +-
agents/windows/sections/SectionPerfcounter.h | 1 -
agents/windows/sections/SectionPluginGroup.cc | 13 ++-
agents/windows/sections/SectionPluginGroup.h | 2 -
agents/windows/sections/SectionServices.cc | 5 +-
agents/windows/sections/SectionSkype.cc | 2 +-
agents/windows/sections/SectionSpool.cc | 5 +-
agents/windows/sections/SectionSpool.h | 3 -
agents/windows/sections/SectionSystemtime.cc | 4 +-
agents/windows/sections/SectionUptime.cc | 4 +-
agents/windows/sections/SectionWMI.cc | 21 ++++-
agents/windows/sections/SectionWMI.h | 3 +-
agents/windows/sections/SectionWinperf.cc | 4 +-
agents/windows/test/sections/SectionHeaderTest.cc | 67 ++++++++++++++
33 files changed, 326 insertions(+), 97 deletions(-)
Diff:
http://git.mathias-kettner.de/git/?p=check_mk.git;a=commitdiff;h=85386fd44b…