Branch: refs/heads/2.0.0 Home: https://github.com/tribe29/checkmk Commit: 84aff059537fd7c01b2a358353014891f2f37f57 https://github.com/tribe29/checkmk/commit/84aff059537fd7c01b2a358353014891f… Author: Benedikt Seidl <benedikt.seidl(a)tribe29.com> Date: 2021-04-15 (Thu, 15 Apr 2021) Changed paths: A .werks/12313 M cmk/base/plugins/agent_based/utils/diskstat.py M tests/unit/cmk/base/plugins/agent_based/test_diskstat.py M tests/unit/cmk/base/plugins/agent_based/utils/test_diskstat_utils.py Log Message: ----------- 12313 FIX checks: diskstat: Fix predictive values Disk IO should now be able to display predictive values. Before this fix checkmk crashed with a KeyError. SUP-5924 Change-Id: Ic9ec62ebd3d69c8b86c212d409ae9d736a2f28a7 Commit: 3ecae0bc503f6a2e5fafdb5daba64404e62cafda https://github.com/tribe29/checkmk/commit/3ecae0bc503f6a2e5fafdb5daba64404e… Author: Benedikt Seidl <benedikt.seidl(a)tribe29.com> Date: 2021-04-15 (Thu, 15 Apr 2021) Changed paths: A .werks/12315 M cmk/base/plugins/agent_based/liebert_temp_air.py M cmk/base/plugins/agent_based/utils/temperature.py M tests/unit/cmk/base/plugins/agent_based/test_liebert_temp_air.py M tests/unit/cmk/base/plugins/agent_based/utils/test_temperature.py Log Message: ----------- 12315 FIX check: liebert_temp_air: fix Attribute Error The check liebert_temp_air crashed with "AttributeError ('NoneType' object has no attribute 'get')". This should now be fixed. There were multiple issues: * value_store was not typed at all, or wrongly typed as string * the value_store value was not provided (thus the error) * in `check_temperature` `get_rate` is called (via `_check_trend`) twice, with the same key and the same value. The second call to get_rate probably always returned 0. The tests with freezegun raised an error because get_rate detected no time change. SUP-5997 Change-Id: Ie268edad24ccaa6fbaf13b82b20900647e52bfa8 Compare: https://github.com/tribe29/checkmk/compare/c479758c78a6...3ecae0bc503f