Branch: refs/heads/master
Home:
https://github.com/tribe29/checkmk
Commit: 0fe6f49f38874bdca3c80b281afd5ea1e600819b
https://github.com/tribe29/checkmk/commit/0fe6f49f38874bdca3c80b281afd5ea1e…
Author: Lars Michelsen <lm(a)tribe29.com>
Date: 2019-11-19 (Tue, 19 Nov 2019)
Changed paths:
A .werks/10385
M docker/Dockerfile
M docker/Makefile
M tests-py3/docker/test_docker.py
M tests/testlib/utils.py
Log Message:
-----------
10385 FIX Do not expose download credentials to the image history
The previous "docker build" mechanism was using docker build arguments for
handing over the Checkmk enterprise download credentials to the docker image
build procedure. This was making the credentials available in the meta
information of the docker image, which may not be acceptable in many
situations.
If you simply want to use the Checkmk docker container, you don't need to care
about the details below. This is just relevant for the ones building own docker
images with Checkmk using the standard build logic.
This change switches the image build logic to use a small busybox based
container during image building that manages the secret download
credentials and provides it to the "docker build" command. These will
either be stopped and removed after the build finished successfully or
after 180 seconds.
If you build images on your own, you don't have to change anything if
you use our build logic (docker/Makefile).
Change-Id: I67de6a0f2f7e0196bc7d1c3d2bcabdaf43e28a46