Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 00b1bad4c42853853deb7bb371a7160949d5c7b0 https://github.com/tribe29/checkmk/commit/00b1bad4c42853853deb7bb371a716094… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2020-12-10 (Thu, 10 Dec 2020) Changed paths: M cmk/base/checkers/snmp.py M cmk/fetchers/snmp.py M tests/unit/cmk/fetchers/test_fetchers.py Log Message: ----------- Revert "Revert "Pass `snmp_fetch_interval` to fetcher"" Currently, we use the second field from the value of the PersistedSections to decide whether the cache should be invalidated or not. This field contains the unix time computed from the first field (the unix time when the data was cached) and the fetch interval at the time the value was cached. However, the computation is not updated when the user modifies the fetch interval. There is therefore no guarantee that the value from the DB is correct at any time after caching. Instead of using the value in the DB, we must always use the currently configured interval and we therefore: 1. pass the configured values to the fecther (this patch) and 2. compute the invalidation date from the first field and the current interval. Actually, the second field should *never* be used. CMK-6516 This reverts commit e0940cecea445c2478bb1af6fcaa562779265099. Change-Id: I91727e42e38880debb0e00f3368ef24296e26ecf Commit: 5166da0fcec9a4637bf5d88c3db2498fa8837138 https://github.com/tribe29/checkmk/commit/5166da0fcec9a4637bf5d88c3db2498fa… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2020-12-10 (Thu, 10 Dec 2020) Changed paths: M cmk/base/checkers/snmp.py M cmk/base/config.py M cmk/fetchers/snmp.py M tests/unit/cmk/base/test_config.py Log Message: ----------- Set fetch interval unit to seconds Timestamps in Python are typically given in seconds. Having a time delta in minutes is thus unexpected. Moreover, it is error prone as *every* user of this timestamp must multiply the value by 60. This patch lets the accessor from `config` return the value in seconds. CMK-6516 Change-Id: I1d6bf6da8192f186179311f9fb3101f26f9d5d0d Commit: 87ba8fb6bfe1c548c3aa75222d04cb47978946ec https://github.com/tribe29/checkmk/commit/87ba8fb6bfe1c548c3aa75222d04cb479… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2020-12-10 (Thu, 10 Dec 2020) Changed paths: M cmk/fetchers/cache.py Log Message: ----------- Remove DB on store (was load) Semantically, one may expect that the DB is modified on disk upon store but *not* upon load. Modifying the DB on load *is* confusing. CMK-6516 Change-Id: I50e621bb9b6f63a9ed514c7663f8ec2802bdf082 Commit: a78b48e2c7f21f8f03e7b4b968c38f3a89c268fc https://github.com/tribe29/checkmk/commit/a78b48e2c7f21f8f03e7b4b968c38f3a8… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2020-12-10 (Thu, 10 Dec 2020) Changed paths: M cmk/base/checkers/agent.py M cmk/base/checkers/snmp.py M cmk/fetchers/cache.py M cmk/fetchers/snmp.py M tests/unit/cmk/base/checkers/test_agent.py M tests/unit/cmk/base/checkers/test_snmp.py M tests/unit/cmk/fetchers/test_cache.py Log Message: ----------- Move PersistedSection filtering to PersistedSections Now we have the following methods * SectionStore.load() loads the DB and returns its content. * SectionStore.store() updates the DB with new content or removes it if it is empty. * PersistedSections.filter() filters the persisted sections in place. Moving the filtering from the SectionStore to the PersistedSections reduces feature envy and lets the SectionStore class manage the DB but ignore its content. Note that the filtering criterion is not correct but this patch does not change the behavior of the code but only its API. We also add a few comments that explain the current code duplication and provide a solution to get rid of it. CMK-6516 Change-Id: Ic43bd104c08ea047cb42edb59db92c7bced4a454 Compare: https://github.com/tribe29/checkmk/compare/1277f6c1d49b...a78b48e2c7f2