Branch: refs/heads/master
Home:
https://github.com/tribe29/checkmk
Commit: b1c37217282ba013b7118287a4723c200aa3f204
https://github.com/tribe29/checkmk/commit/b1c37217282ba013b7118287a4723c200…
Author: Mathias Laurin <mathias.laurin(a)tribe29.com>
Date: 2022-03-02 (Wed, 02 Mar 2022)
Changed paths:
M cmk/utils/password_store.py
Log Message:
-----------
Clarify relationship between Encrypter and _PasswordStoreObfuscator
A class with only classmethods is not a class in the traditional OO
sense but a collection of free functions in a namespace. Inheriting a
namespace with free functions (aka inheriting functions) is uncommon.
Even if we had a class in the traditional OO sense, implementation
inheritance is usually frowned upon. So let us remove the inheritance.
The way the API functions: encrypt and decrypt used to cut the header in
the obfuscated password store was also rather counter-intuitive.
Change-Id: I1c703b516feb58d2b0f0ab72cb3c32a6bd7f97c9
Commit: b84a45be5c0a3506808bb017e8ffea3885b18c5f
https://github.com/tribe29/checkmk/commit/b84a45be5c0a3506808bb017e8ffea388…
Author: Mathias Laurin <mathias.laurin(a)tribe29.com>
Date: 2022-03-02 (Wed, 02 Mar 2022)
Changed paths:
M cmk/update_config.py
M cmk/utils/encryption.py
M cmk/utils/password_store.py
M tests/unit/cmk/utils/test_password_store.py
Log Message:
-----------
Clarify relationship between Encrypter and _PasswordStoreObfuscator #2
A class with only classmethods is not a class in the traditional OO
sense but a collection of free functions in a namespace. Replacing
the classmethod decorators with staticmethods makes this fact clear.
This patch also shortens the name of the _PasswordStoreObfuscator for
into PasswordStore readability and consistency.
Change-Id: Ibbba54322ed9a7d66a4d724856985a89e46d7feb
Compare:
https://github.com/tribe29/checkmk/compare/4e8a1199cc7d...b84a45be5c0a