Branch: refs/heads/master
Home:
https://github.com/tribe29/checkmk
Commit: b07afcdedf42bd6a95b81e410740456a935fcc0d
https://github.com/tribe29/checkmk/commit/b07afcdedf42bd6a95b81e410740456a9…
Author: Max Linke <max.linke(a)tribe29.com>
Date: 2022-06-27 (Mon, 27 Jun 2022)
Changed paths:
M cmk/base/plugins/agent_based/gcp_filestore.py
M cmk/base/plugins/agent_based/gcp_function.py
M cmk/base/plugins/agent_based/gcp_gcs.py
M cmk/base/plugins/agent_based/gcp_redis.py
M cmk/base/plugins/agent_based/gcp_run.py
M cmk/base/plugins/agent_based/gcp_sql.py
M cmk/base/plugins/agent_based/utils/gcp.py
M tests/unit/cmk/base/plugins/agent_based/test_gcp_sql.py
Log Message:
-----------
refactor gcp checks
There was a lot of duplicate code between the check plugins. By
refactoring this we ensure now that almost all checks have the same behavior.
Furthermore it means in the future we only need to change one part of
the code to modify behavior.
Change-Id: Id6f61ba5fd54baf3ec05383cad3ed3e45faf9581
Commit: 33727f42686fe1060c4b818225616ce6ac003dd6
https://github.com/tribe29/checkmk/commit/33727f42686fe1060c4b818225616ce6a…
Author: Max Linke <max.linke(a)tribe29.com>
Date: 2022-06-27 (Mon, 27 Jun 2022)
Changed paths:
M tests/unit/cmk/base/plugins/agent_based/gcp_test_util.py
M tests/unit/cmk/base/plugins/agent_based/test_gcp_function.py
Log Message:
-----------
Add generic data generator for gcp tests
Change-Id: I8457b90b1fcfbecbe63b7dbb33d4deefb696ffe1
Commit: b2554b4344b13b5490fd1ee451a8829f98e6ee60
https://github.com/tribe29/checkmk/commit/b2554b4344b13b5490fd1ee451a8829f9…
Author: Max Linke <max.linke(a)tribe29.com>
Date: 2022-06-27 (Mon, 27 Jun 2022)
Changed paths:
M tests/unit/cmk/base/plugins/agent_based/gcp_test_util.py
M tests/unit/cmk/base/plugins/agent_based/test_gcp_function.py
Log Message:
-----------
rewrite gcp function tests
GCP check plugin tests have been a bit all over the place. This is the
first step to get a test concept implemented for gcp plugins.
In the tests we want to test generic behavior just once. Generic
behavior is that the check parameters are adhered to. That a plugin
behaves correct if data is missing. We do this only once because the
assumption is that all gcp check plugins use the identical
implementation function from ...agent_based.utils.gcp.
What we do want to test for every check plugin is that the configuration
of check is correct. That includes we generate the correct number of
results and metrics, metrics have the expected names, and results have
the correct summary and details. Those vary between plugins. By using
the generic test data generator that works on the SERVICE definitions of
the gcp agent we can also ensure that the check plugin configurations
look for the correct timeseries in the section data.
After this all gcp test can skip the generic behavior test without losing
any test coverage.
Change-Id: Ic2b049e660ad78904b257613fed7e251437fee58
Commit: 555fc22d78ffc3d105509e9e69ec91b1e7ebea83
https://github.com/tribe29/checkmk/commit/555fc22d78ffc3d105509e9e69ec91b1e…
Author: Max Linke <max.linke(a)tribe29.com>
Date: 2022-06-27 (Mon, 27 Jun 2022)
Changed paths:
M tests/unit/cmk/base/plugins/agent_based/test_gcp_filestore.py
Log Message:
-----------
simplify gcp filestore tests
Change-Id: Iac58cecd1b5263749db5a8d18686ff01bfa85477
Commit: 92e5dc59fec74f0390e147387990c352dafaefbf
https://github.com/tribe29/checkmk/commit/92e5dc59fec74f0390e147387990c352d…
Author: Max Linke <max.linke(a)tribe29.com>
Date: 2022-06-27 (Mon, 27 Jun 2022)
Changed paths:
M cmk/base/plugins/agent_based/gcp_gcs.py
M tests/unit/cmk/base/plugins/agent_based/test_gcp_gcs.py
M tests/unit/cmk/base/plugins/agent_based/test_synology_disk.py
Log Message:
-----------
simplify gcp gcs tests
Change-Id: I5335ba1db8d915e243efc5bc336dbb53dd383d79
Commit: ed6b08a6af5072788db84435a0c6ead8bf1c2c36
https://github.com/tribe29/checkmk/commit/ed6b08a6af5072788db84435a0c6ead8b…
Author: Max Linke <max.linke(a)tribe29.com>
Date: 2022-06-27 (Mon, 27 Jun 2022)
Changed paths:
M tests/unit/cmk/base/plugins/agent_based/test_gcp_redis.py
Log Message:
-----------
simplify gcp redis tests
Change-Id: I5d259996325a7b67a6ed1bcc0fec898c8f04c819
Commit: c636ef83bb7285c2e1347284710b7b7bb49d1bcd
https://github.com/tribe29/checkmk/commit/c636ef83bb7285c2e1347284710b7b7bb…
Author: Max Linke <max.linke(a)tribe29.com>
Date: 2022-06-27 (Mon, 27 Jun 2022)
Changed paths:
M cmk/base/plugins/agent_based/gcp_sql.py
M tests/unit/cmk/base/plugins/agent_based/test_gcp_sql.py
Log Message:
-----------
simplify gcp cloudsql tests
Change-Id: I2381e03ec03c107916c5da7701be8d69f31e3217
Commit: fd9ac9d1276c2b8a1f7c19ee141d5ad36b08be2b
https://github.com/tribe29/checkmk/commit/fd9ac9d1276c2b8a1f7c19ee141d5ad36…
Author: Max Linke <max.linke(a)tribe29.com>
Date: 2022-06-27 (Mon, 27 Jun 2022)
Changed paths:
M cmk/base/plugins/agent_based/gcp_run.py
M cmk/special_agents/agent_gcp.py
M tests/unit/cmk/base/plugins/agent_based/test_gcp_run.py
Log Message:
-----------
refactor gcp run
update tests to follow new testing of check configuration. This is
currently special for cloud run because I do not know how to generalize
the additional filters in the query to gcp.
This discovered 2 mistakes in the configuration of the requests check.
Change-Id: Ied717a28ac8db722a16180b4290ca5f2e6b566c2
Commit: 5da36e88dfb0426fedc51bec38b1d889711ab4f8
https://github.com/tribe29/checkmk/commit/5da36e88dfb0426fedc51bec38b1d8897…
Author: Max Linke <max.linke(a)tribe29.com>
Date: 2022-06-27 (Mon, 27 Jun 2022)
Changed paths:
M cmk/special_agents/agent_gcp.py
M tests/unit/cmk/special_agents/test_agent_gcp.py
Log Message:
-----------
pass agent config to asset section of gcp agent
Change-Id: I561c141794770173dc1d60f8f9ca673d6afe89fe
Compare:
https://github.com/tribe29/checkmk/compare/f27a98306f5c...5da36e88dfb0