Module: check_mk
Branch: master
Commit: d53aa6236c566bc04bcbf7ea1a3f1e832ec77230
URL:
http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=d53aa6236c566b…
Author: Sven Panne <sp(a)mathias-kettner.de>
Date: Fri Jun 15 08:55:29 2018 +0200
Removed two import cycles related to the check API.
This brings the number of cycles down to 3 (from 5).
Threading through things doesn't win a beauty contest, but this doesn't
matter at all here: Removing cycles is far more important than some vague
aesthetic issues.
Once again, threading through things is a clear sign of some missing
abstraction, in our case: We are missing a self-contained class/module
representing our check API.
Change-Id: Ieb9e4be113c4eb5d9ee42f2993acc70aeb5390bc
---
bin/check_mk | 3 ++-
cmk_base/automations/__init__.py | 3 ++-
cmk_base/automations/check_mk.py | 3 ++-
cmk_base/check_api.py | 4 ++--
cmk_base/checking.py | 3 +--
cmk_base/checks.py | 13 ++++++-------
cmk_base/core_nagios.py | 3 ++-
cmk_base/inventory.py | 3 ++-
cmk_base/inventory_plugins.py | 8 ++++----
cmk_base/modes/check_mk.py | 6 ++++--
tests/integration/cmk_base/test_check_variables.py | 7 ++++---
tests/integration/cmk_base/test_data_sources.py | 3 ++-
tests/integration/cmk_base/test_mgmt_board.py | 3 ++-
tests/testlib/__init__.py | 6 ++++--
tests/unit/cmk/test_man_pages.py | 3 ++-
tests/unit/cmk_base/test_checks.py | 9 +++++----
16 files changed, 46 insertions(+), 34 deletions(-)
Diff:
http://git.mathias-kettner.de/git/?p=check_mk.git;a=commitdiff;h=d53aa6236c…