Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 8bcafdf59aea813b06f064a180ba05e973f4bf89 https://github.com/tribe29/checkmk/commit/8bcafdf59aea813b06f064a180ba05e97… Author: Óscar Nájera <oscar.najera(a)tribe29.com> Date: 2020-09-29 (Tue, 29 Sep 2020) Changed paths: M cmk/gui/valuespec.py M tests/unit/cmk/gui/test_valuespec.py Log Message: ----------- Fix and clean cascadingdropdown choice and text render CascadingDropdowns declare the identification of their value as the value itself. When a choices can be configured over a ValueSpec, the identification should be a string and the configured value a Tuple[str, Any], yet mypy wont agree and wants Tuple[Ident, Any].(To be resolved) The weak distinction between identification/value and configured value allowed an abuse in Werk 4477, to set default values on the choices as a configuration for the Timerange valuespec. In this commit. Types for identification and value, are marked. For non-disruptive compatibility on user set graph timeranges(Werk 4477), a value_to_text is added to the Timerange. CMK-5668 Change-Id: I74efb5315a8d77debb6db25698e1dd4334c016f6 Commit: da9131e91075ab48f7286667d378807b24f170e8 https://github.com/tribe29/checkmk/commit/da9131e91075ab48f7286667d378807b2… Author: Óscar Nájera <oscar.najera(a)tribe29.com> Date: 2020-09-29 (Tue, 29 Sep 2020) Changed paths: M cmk/gui/valuespec.py M tests/unit/cmk/gui/test_valuespec.py Log Message: ----------- New default casting on Timerange CMK-5668 Change-Id: I2294c44275d4dd06f1f12047c31fb1a9247ade98 Commit: 7247638454d520a3d752b8f72f802192f942d8fd https://github.com/tribe29/checkmk/commit/7247638454d520a3d752b8f72f802192f… Author: Óscar Nájera <oscar.najera(a)tribe29.com> Date: 2020-09-29 (Tue, 29 Sep 2020) Changed paths: M cmk/gui/valuespec.py Log Message: ----------- Cleanup cascadingdropdown transforms to-from json This is only a cleanup, which does not fix bugs in this fragile code, it just keeps it working as it was, bugs can be fixed when they arise. CMK-5668 Change-Id: I1694046dbd03cad922c29c60903f1708f61928fb Compare: https://github.com/tribe29/checkmk/compare/554a271f7a46...7247638454d5