Module: check_mk
Branch: master
Commit: 36a9ac8ac9bb840d5efb0207c5d9892b2e822c40
URL:
http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=36a9ac8ac9bb84…
Author: Andreas Boesl <ab(a)mathias-kettner.de>
Date: Tue Feb 3 12:04:24 2015 +0100
Updated bug entries #2170
---
.bugs/2170 | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
diff --git a/.bugs/2170 b/.bugs/2170
new file mode 100644
index 0000000..48288bd
--- /dev/null
+++ b/.bugs/2170
@@ -0,0 +1,17 @@
+Title: ensure that the params parameter is not modified within checks
+Component: checks
+State: open
+Date: 2015-02-03 11:55:21
+Targetversion: future
+Class: cleanup
+
+Example check: fritz
+
+ if 'assumed_speed_in' not in params:
+ params['assumed_speed_in'] =
int(data['NewLayer1DownstreamMaxBitRate'])
+
+This type of assignment actively modifies the params dictionary -> not allowed
+
+How to find such checks:
+Make a comparision between the parameters before and after the execution of the check
function
+Any variation results either in an Exception or an output to stderr.