Branch: refs/heads/master
Home:
https://github.com/Checkmk/checkmk
Commit: bc6e3fa375a1dc50f0cc6f278fc933437ff8953c
https://github.com/Checkmk/checkmk/commit/bc6e3fa375a1dc50f0cc6f278fc933437…
Author: Dhananjay Shah <dhananjay.shah(a)checkmk.com>
Date: 2024-04-08 (Mon, 08 Apr 2024)
Changed paths:
M tests/testlib/playwright/helpers.py
M tests/testlib/playwright/pom/dashboard.py
M tests/testlib/playwright/pom/navigation.py
M tests/testlib/playwright/timeouts.py
Log Message:
-----------
gui-e2e test: streamline usage of 'timeout's.
+ Base page-object(LocatorHelper) accepts two type of timeouts
* timeout for assertions, used for code such as
`except(...).to_be_visible()`
by default, 15 seconds.
* timeout for navigation, used for code such as
`page.locator("web-element").click()` or
`page.goto("url")`
by default, 30 seconds
Code can be seen within `LocatorHelper::__init__`.
Change-Id: I4dc473c959de53551274d88049bc889795d5c1fb
Commit: 5212783317a33dc24a2a52e371837f73ae1dea7a
https://github.com/Checkmk/checkmk/commit/5212783317a33dc24a2a52e371837f73a…
Author: Dhananjay Shah <dhananjay.shah(a)checkmk.com>
Date: 2024-04-08 (Mon, 08 Apr 2024)
Changed paths:
M tests/testlib/playwright/pom/navigation.py
Log Message:
-----------
gui-e2e tests: overload 'locator' method in "MainArea",
"MainMenu".
+ return iframe and menu location, respectively, if no selector is provided.
+ Enable usage of "main_area.get_by_role" (FrameLocator.get_by_role)
there is a difference in earlier default behaviour of
main_area.locator("xpath=.").get_by_role (<Locator
object>.<action>)
and
main_area.get_by_role (<FrameLocator object>.<action>)
Change-Id: If19203f24ae3811a3bba9ac32efccd98ed863a25
Commit: dd65dcdfe30dab483aabf7e9ab3246d1833e4828
https://github.com/Checkmk/checkmk/commit/dd65dcdfe30dab483aabf7e9ab3246d18…
Author: Dhananjay Shah <dhananjay.shah(a)checkmk.com>
Date: 2024-04-08 (Mon, 08 Apr 2024)
Changed paths:
M tests/testlib/playwright/helpers.py
M tests/testlib/playwright/pom/navigation.py
Log Message:
-----------
gui-e2e tests: move 'click_and_wait' method to 'LocatorHelper'.
+ "click_and_wait" needs to be accessed by MainArea and MainMenu, as well.
+ improvements to "click_and_wait"
* accepts Locator, Frame or Page as an object
* Assertion displays the latest exception.
+ added new method `CmkPage::get_link`
* wraps playwright code `get_by_role(role="link", ...)`
+ updates wrt consistent type-hinting.
Change-Id: I139ac9bd8ae9bf819ccd9609b597fe7e855e455b
Commit: dedad588054a8baedec52ab62d05020b5ac4ad5f
https://github.com/Checkmk/checkmk/commit/dedad588054a8baedec52ab62d05020b5…
Author: Dhananjay Shah <dhananjay.shah(a)checkmk.com>
Date: 2024-04-08 (Mon, 08 Apr 2024)
Changed paths:
M tests/gui_e2e/test_hosts.py
M tests/testlib/playwright/pom/navigation.py
A tests/testlib/playwright/pom/setup/hosts.py
Log Message:
-----------
gui-e2e tests: Add PoM for `setup -> Hosts`
+ added "SetupHost"
+ consists of method to create host
+ added "HostProperties"
+ creates a host automatically, if one doesn't exist.
+ consists of method to delete host
+ add methods within "CmkPage"
+ "get_link": used to get web-elements having role="link"
+ "goto": override "Page.goto"; additionally validates
"load" event.
+ migrate "gui_e2e.test_hosts::TestHost"
to
"testlib.playwright.pom.setup.hosts::HostDetails"
+ Update 'test_create_and_delete_a_host' (as a firtst).
+ use PoM "HostProperties" within the test-case.
Change-Id: I2e4deae399a812a31f9e696ebf22dbbe611df5bd
Commit: 78917050f9a7bff8a8e48b3ffff082ae7b67b13f
https://github.com/Checkmk/checkmk/commit/78917050f9a7bff8a8e48b3ffff082ae7…
Author: Dhananjay Shah <dhananjay.shah(a)checkmk.com>
Date: 2024-04-08 (Mon, 08 Apr 2024)
Changed paths:
M tests/gui_e2e/test_hosts.py
M tests/testlib/playwright/pom/setup/hosts.py
Log Message:
-----------
gui-e2e tests: Update "test_hosts" to use PoM.
+ adapt tests to use test-fixture enabled by using "HostProperties".
+ migrate page related attributes to "HosProperties"
such as list of popup-menus, links and page-properties
+ remove redundant code
test-code to create and delete hosts,
which has been moved to PoM "HosProperties" already.
Change-Id: I33e90b42868aa22978cd6c9e4b63d9cd13d1ffaf
Commit: d38ade931549bf839c136bdef8cb8cf3232b9721
https://github.com/Checkmk/checkmk/commit/d38ade931549bf839c136bdef8cb8cf32…
Author: Dhananjay Shah <dhananjay.shah(a)checkmk.com>
Date: 2024-04-08 (Mon, 08 Apr 2024)
Changed paths:
M tests/gui_e2e/test_hosts.py
M tests/testlib/playwright/pom/dashboard.py
M tests/testlib/playwright/pom/navigation.py
M tests/testlib/playwright/pom/setup/hosts.py
Log Message:
-----------
gui-e2e tests: encapsulate ´navigation´ steps.
**Major**
+ encapsulate steps required to navigate to a page.
+ method `navigate` is an `abstractmethod`
+ it must be defined in an page object.
+ reusable using `super().__init__`,
as it is called within the `CmkPage.__init__`.
+ update methods `create_user` and `delete_user`. Added *assumption*
+ actions performed are within the context of corresponding pages
+ Why ?
Methods are specific to a page under consideration.
They are expected to work ONLY in the context of the page.
**Minor**
+ docstring updates
+ added TODO to define `LoginPage::navigate`.
+ updates to affected test-cases.
CMK-16734
Change-Id: I05bdf956daa6abc153b638096c949a90270df74a
Compare:
https://github.com/Checkmk/checkmk/compare/561cad548631...d38ade931549
To unsubscribe from these emails, change your notification settings at
https://github.com/Checkmk/checkmk/settings/notifications