Branch: refs/heads/master
Home:
https://github.com/tribe29/checkmk
Commit: ec6c921d05ee201dcbc7f66cce6fd9381105eb7c
https://github.com/tribe29/checkmk/commit/ec6c921d05ee201dcbc7f66cce6fd9381…
Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com>
Date: 2021-01-14 (Thu, 14 Jan 2021)
Changed paths:
M checks/oracle_undostat
M tests/unit/checks/generictests/datasets/oracle_undostat.py
M tests/unit/cmk/base/plugins/agent_based/test_section_properties.py
Log Message:
-----------
oracle_undostat: refactor
Make some changes to prepare for the upcoming 'PRO TIP'
* add parse function
* add check_levels
* format "unit" test
Change-Id: If95f12d273ffa4375b3b307f904c2e6fabe540c9
Commit: f25938789912842ce8d29cf89e8b040b3b7a1af8
https://github.com/tribe29/checkmk/commit/f25938789912842ce8d29cf89e8b040b3…
Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com>
Date: 2021-01-14 (Thu, 14 Jan 2021)
Changed paths:
M checks/oracle_undostat
M tests/unit/checks/generictests/datasets/oracle_undostat.py
Log Message:
-----------
PRO TIP: use generator functions
The new check API requires the discovery and check
functions to be generator functions. However, this is
also supported by the old API, and makes things much
easier.
If you yield single results instead of aggregating them
yourself, Checkmk will take care of many things for you:
* The individual results will be joined by ', '
* The service state will be the worst of the individual
states. No need to keep track of the worst using lines
like `state = max(state, state_errcnt)`
* Every individual result that is not OK will be highlighted
by the GUI - no need to add markers like '(!!)'
* Note in the second test case how the WARN state is no
longer obfuscated
Change-Id: Ib606445a83d182a750f66de6f622dee1923a958a
Compare:
https://github.com/tribe29/checkmk/compare/18ffefc0dd5c...f25938789912