Module: check_mk
Branch: master
Commit: 690128b3a5138d041bbb83313bfeb0d51f054695
URL:
http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=690128b3a5138d…
Author: Mathias Kettner <mk(a)mathias-kettner.de>
Date: Fri Apr 8 09:56:58 2016 +0200
3394 Availability: Annotations can now be used to reclassify the scheduled downtime
status
The availability computation of hosts and services now allows to use the
existing {{Annotations}} in order to reclassify the annotated periods as
having been in scheduled downtime or even as not having been in scheduled
downtime. That way you can fix your figures in case one has forgotten to enter
a scheduled downtime in the past or in the case that scheduled downtimes
were just used in order to disable notifications (but the breakdown was in
fact real and not scheduled).
Availability of BI aggregations currently does not support annotations or any
reclassifications. Neither does it honor reclassifications in the underlying
host and service history.
---
.werks/3394 | 19 +++++++++++++++++++
ChangeLog | 1 +
web/htdocs/availability.py | 4 ++--
web/plugins/views/availability.py | 6 ------
4 files changed, 22 insertions(+), 8 deletions(-)
diff --git a/.werks/3394 b/.werks/3394
new file mode 100644
index 0000000..537b617
--- /dev/null
+++ b/.werks/3394
@@ -0,0 +1,19 @@
+Title: Availability: Annotations can now be used to reclassify the scheduled downtime
status
+Level: 2
+Component: reporting
+Compatible: compat
+Version: 1.2.9i1
+Date: 1460101981
+Class: feature
+
+The availability computation of hosts and services now allows to use the
+existing {{Annotations}} in order to reclassify the annotated periods as
+having been in scheduled downtime or even as not having been in scheduled
+downtime. That way you can fix your figures in case one has forgotten to enter
+a scheduled downtime in the past or in the case that scheduled downtimes
+were just used in order to disable notifications (but the breakdown was in
+fact real and not scheduled).
+
+Availability of BI aggregations currently does not support annotations or any
+reclassifications. Neither does it honor reclassifications in the underlying
+host and service history.
diff --git a/ChangeLog b/ChangeLog
index a485aa0..821623d 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -257,6 +257,7 @@
Reporting & Availability:
* 3267 New availability option for reclassifying host state
"unreachable"...
* 3102 added option to availability to include host alias in reports...
+ * 3394 Availability: Annotations can now be used to reclassify the scheduled downtime
status...
* 3249 FIX: Fix missing filter for non-OK services when report is called via context
button
* 3268 FIX: Availability options were invalid after resetting them...
* 3269 FIX: Fix rendering of floating point values < 1 in graphs (e.g. CPU load)
diff --git a/web/htdocs/availability.py b/web/htdocs/availability.py
index d05b2c5..43115df 100644
--- a/web/htdocs/availability.py
+++ b/web/htdocs/availability.py
@@ -762,8 +762,8 @@ def compute_availability(what, av_rawdata, avoptions):
return filtered_table
-# TODO: Wir müssen auch den Fall behandeln, dass ein Host reklassifiert wird.
-# dann müssen die Services das Feld in_host_downtime ebenfalls nachziehen!
+# Note: Reclassifications of host/service periods do currently *not* have
+# any impact on BI aggregations.
def reclassify_by_annotations(what, av_rawdata):
annotations = load_annotations()
if not annotations:
diff --git a/web/plugins/views/availability.py b/web/plugins/views/availability.py
index 47a238b..7f57dc7 100644
--- a/web/plugins/views/availability.py
+++ b/web/plugins/views/availability.py
@@ -24,12 +24,6 @@
# to the Free Software Foundation, Inc., 51 Franklin St, Fifth Floor,
# Boston, MA 02110-1301 USA.
-# ZUTUN / TODO:
-#
-# - Test mit Hosts und BI-Aggregaten
-# - Host-Annotations nicht mehrfach zeigen!
-
-
import availability, table
from valuespec import *