Branch: refs/heads/master
Home:
https://github.com/tribe29/checkmk
Commit: 613a82baea3725cead80bfa312b8663c24b6478b
https://github.com/tribe29/checkmk/commit/613a82baea3725cead80bfa312b8663c2…
Author: Mathias Laurin <mathias.laurin(a)tribe29.com>
Date: 2020-03-26 (Thu, 26 Mar 2020)
Changed paths:
M cmk/base/data_sources/programs.py
Log Message:
-----------
static + rename ProgramDS._fetch_raw_data
We rename the method as in the TCP data source and make it static to
emphasize that the method is independant from the class.
CMK-3742
Change-Id: Ic0312bec40cd27c661185ef72bed84f856225bc3
Commit: 99d01342cda69a1836723e97154f0c2da2908a15
https://github.com/tribe29/checkmk/commit/99d01342cda69a1836723e97154f0c2da…
Author: Mathias Laurin <mathias.laurin(a)tribe29.com>
Date: 2020-03-26 (Thu, 26 Mar 2020)
Changed paths:
M cmk/base/data_sources/programs.py
M tests-py3/unit/cmk/base/data_sources/test_program_data_source.py
Log Message:
-----------
Split ProgramDS._get_command_line_and_stdin
This splits the method into two: `source_cmdline` and `source_stdin`.
Both attributes are rather independent. The added flexibility of having
two attributes instead of a method allows us to get rid of local
variables. This also makes the classes easier to test.
It also is now evident that `source_stdin` only exists for
SpecialAgentDataSource. The fact that nearly every statement in
`_fetch_raw_data()` checks whether `stdin` is None demonstrates another
desing problem.
CMK-3742
Change-Id: I04b583ada93cc57d26dfe3a4066bce65bb38dcba
Compare:
https://github.com/tribe29/checkmk/compare/d8d32e87b080...99d01342cda6