id input fields
Message-ID: <57a05b7a.CPHk4tQ5Q73sHgmU%lm(a)mathias-kettner.de>
User-Agent: Heirloom mailx 12.5 6/20/10
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Module: check_mk
Branch: master
Commit: 7293a4a5ef2608c61977b49d43b4eb3d98d5185d
URL:
http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=7293a4a5ef2608…
Author: Lars Michelsen <lm(a)mathias-kettner.de>
Date: Tue Aug 2 10:35:56 2016 +0200
3733 FIX BI rule editor: Increased size of argument/parameter/id input fields
---
.werks/3733 | 9 +++++++++
ChangeLog | 1 +
web/htdocs/check_mk.css | 3 ---
web/plugins/wato/bi.py | 8 ++++----
4 files changed, 14 insertions(+), 7 deletions(-)
diff --git a/.werks/3733 b/.werks/3733
new file mode 100644
index 0000000..28a5bd9
--- /dev/null
+++ b/.werks/3733
@@ -0,0 +1,9 @@
+Title: BI rule editor: Increased size of argument/parameter/id input fields
+Level: 1
+Component: wato
+Compatible: compat
+Version: 1.4.0i1
+Date: 1470126934
+Class: fix
+
+
diff --git a/ChangeLog b/ChangeLog
index 164cf38..1417ca9 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -517,6 +517,7 @@
* 3718 FIX: Changes not needing a core restart are not showing up pending changes
anymore...
* 3719 FIX: Fixed possible wrong encoding of audit log messages when editing global
settings
* 3726 FIX: Web API: Fixed default output format - using JSON as intended...
+ * 3733 FIX: BI rule editor: Increased size of argument/parameter/id input fields
Notifications:
* 3263 Notifications: allow users to restrict by their contact groups...
diff --git a/web/htdocs/check_mk.css b/web/htdocs/check_mk.css
index eefa989..96f1069 100644
--- a/web/htdocs/check_mk.css
+++ b/web/htdocs/check_mk.css
@@ -524,9 +524,6 @@ div.listofstrings.horizontal > div {
float: left;
margin-right: 2px;
}
-div.listofstrings.horizontal > div:last-child {
- float: none;
-}
table.listchoice {
border-collapse: collapse;
diff --git a/web/plugins/wato/bi.py b/web/plugins/wato/bi.py
index 2d98aa6..4ca024d 100644
--- a/web/plugins/wato/bi.py
+++ b/web/plugins/wato/bi.py
@@ -439,7 +439,7 @@ class ModeBI(WatoMode):
),
ListOfStrings(
orientation = "horizontal",
- size = 12,
+ size = 24,
title = _("Arguments:"),
),
],
@@ -959,7 +959,7 @@ class ModeBIEditPack(ModeBI):
title = _("BI pack ID"),
help = _("A unique ID of this BI pack."),
allow_empty = False,
- size = 12,
+ size = 24,
)
return Dictionary(
title = _("BI Pack Properties"),
@@ -1426,7 +1426,7 @@ class ModeBIEditRule(ModeBI):
"(enclosed in dollar signs)."),
orientation = "horizontal",
valuespec = TextAscii(
- size = 12,
+ size = 24,
regex = '[A-Za-z_][A-Za-z0-9_]*',
regex_error = _("Parameters must contain only A-Z, a-z, 0-9 and
_ "
"and must not begin with a digit."),
@@ -1461,7 +1461,7 @@ class ModeBIEditRule(ModeBI):
"when rules refer to each other. The rule IDs will not be
visible in the status "
"GUI. They are just used within the
configuration."),
allow_empty = False,
- size = 12,
+ size = 24,
),
)] + elements