Module: check_mk
Branch: master
Commit: 599543c336688d3f73dba20ba20a3fcefdb83946
URL:
http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=599543c336688d…
Author: Lars Michelsen <lm(a)mathias-kettner.de>
Date: Tue Feb 5 15:37:28 2013 +0100
FIX: Preventing autocomplete in password fields of "edit profile" dialog
---
.bugs/885 | 7 +++++--
ChangeLog | 1 +
web/htdocs/wato.py | 4 ++--
3 files changed, 8 insertions(+), 4 deletions(-)
diff --git a/.bugs/885 b/.bugs/885
index aa1ce44..4cd4848 100644
--- a/.bugs/885
+++ b/.bugs/885
@@ -1,10 +1,13 @@
Title: Password field in personal settings must not be prefilled by browser
Component: multisite
-State: open
+Class: bug
+State: done
Date: 2013-01-21 15:55:44
Targetversion: 1.2.2
-Class: bug
If the browser enters a possible previous password then after saving
(because of changes to the notifications) the user password gets
changed and the user logged out - forever.
+
+2013-02-05 15:36:48: changed state open -> done
+Just implemented. Added "autocomplete=off" attribute to input fields.
diff --git a/ChangeLog b/ChangeLog
index 8ec9788..9aae64a 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -36,6 +36,7 @@
* Added comment painter to notification related views
* Added compatibility code to use hashlib.md5() instead of md5.md5(), which
is deprecated in python > 2.5 to prevent warning messages in apache error log
+ * FIX: Preventing autocomplete in password fields of "edit profile" dialog
BI:
* Use Ajax to delay rendering of invisible parts of the tree (this
diff --git a/web/htdocs/wato.py b/web/htdocs/wato.py
index f8dd222..18b9a43 100644
--- a/web/htdocs/wato.py
+++ b/web/htdocs/wato.py
@@ -10956,10 +10956,10 @@ def page_user_profile():
if config.may('general.change_password') and not
is_locked('password'):
forms.section(_("Password"))
- html.password_input('password')
+ html.password_input('password', autocomplete = "off")
forms.section(_("Password confirmation"))
- html.password_input('password2')
+ html.password_input('password2', autocomplete = "off")
if config.may('general.edit_profile'):
select_language(config.get_language(''))