Branch: refs/heads/master Home: https://github.com/Checkmk/checkmk Commit: 719d0b37b27c5a41d67ec9329b334a5bed069f61 https://github.com/Checkmk/checkmk/commit/719d0b37b27c5a41d67ec9329b334a5be… Author: Dhananjay Shah <dhananjay.shah(a)checkmk.com> Date: 2024-09-26 (Thu, 26 Sep 2024) Changed paths: M tests/composition/conftest.py M tests/conftest.py M tests/extension_compatibility/conftest.py M tests/gui_crawl/conftest.py M tests/gui_e2e/conftest.py M tests/integration/conftest.py M tests/integration/omd/test_apache.py M tests/plugins_integration/conftest.py M tests/testlib/agent.py M tests/testlib/pytest_helpers/calls.py M tests/testlib/site.py M tests/testlib/utils.py Log Message: ----------- testlib: consistent interface to / usage to `subprocess` methods. + Use methods consistently to execute commands - check_output: `overload` for better typing - run: added `Site.run` - execute: reduce usage wherever not required. + pytest exits on failure of Checkmk site setup. + Log exceptions using `pytest_exception_interact` + `sudo` usage by default are 'False'. CMK-18870 Change-Id: Iab8070c98fdd3df04b14e389dfb30beb75db08b2 Commit: bbdb21c39521c0d1c335de50b104c93c34ece717 https://github.com/Checkmk/checkmk/commit/bbdb21c39521c0d1c335de50b104c93c3… Author: Dhananjay Shah <dhananjay.shah(a)checkmk.com> Date: 2024-09-26 (Thu, 26 Sep 2024) Changed paths: M tests/integration/bin/test_mkbackup.py M tests/integration/cmk/base/test_automations.py M tests/integration/cmk/ec/test_ec.py M tests/integration/cmk/gui/openapi/test_spec_generator.py M tests/integration/notifications/test_simple_rbn.py M tests/integration/omd/test_dcd_integration.py M tests/integration/omd/test_omd.py M tests/integration/omd/test_openssl_using_cmds.py M tests/integration/omd/test_perl.py M tests/integration/omd/test_python_protobuf.py M tests/plugins_integration/checks.py M tests/plugins_integration/conftest.py M tests/update/conftest.py Log Message: ----------- tests: replace `assert `Popen.wait == 0` with `subprocess.run()`. or a form of it through `Site.run` or `tests.testlib.utils::run`, for simplicity. CMK-18870 Change-Id: Ib824a2c3587b08474f3c9b05fa945190f514aad2 Commit: 17f79be8d82e599544fd8b27b18d60823a1089a5 https://github.com/Checkmk/checkmk/commit/17f79be8d82e599544fd8b27b18d60823… Author: Dhananjay Shah <dhananjay.shah(a)checkmk.com> Date: 2024-09-26 (Thu, 26 Sep 2024) Changed paths: M tests/scripts/install-cmk.py M tests/testlib/site.py M tests/testlib/version.py Log Message: ----------- install-cmk: assign distinct returncodes for failures. + Error in installation: returncode 22 raise `RunTimeError` from `testlib.site::Site .install_cmk`. + Error in downloading artifact: returncode 11 raise `FileNotFoundError` from `testlib.site::Site .install_cmk`. CMK-18870 Change-Id: Iaeda202e8f9a15f20d321f9b093629863519e0a9 Compare: https://github.com/Checkmk/checkmk/compare/ba82c4ece36d...17f79be8d82e To unsubscribe from these emails, change your notification settings at https://github.com/Checkmk/checkmk/settings/notifications