Module: check_mk
Branch: master
Commit: 79f594d40bda334a3a272f11287a9faa39fddf54
URL:
http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=79f594d40bda33…
Author: Sven Panne <sp(a)mathias-kettner.de>
Date: Mon Oct 26 13:08:07 2015 +0100
Warning police: Added a few TODOs for now.
---
livestatus/src/TableStateHistory.cc | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
diff --git a/livestatus/src/TableStateHistory.cc b/livestatus/src/TableStateHistory.cc
index 1c92df1..b2580d6 100644
--- a/livestatus/src/TableStateHistory.cc
+++ b/livestatus/src/TableStateHistory.cc
@@ -368,6 +368,14 @@ void TableStateHistory::answerQuery(Query *query)
key = 0;
bool is_service = false;
switch (entry->_type) {
+ case NONE:
+ case CORE_STARTING:
+ case CORE_STOPPING:
+ case LOG_VERSION:
+ case ACKNOWLEDGE_ALERT_HOST:
+ case ACKNOWLEDGE_ALERT_SERVICE:
+ // TODO: Check if a no-op is really the right thing to do here.
+ break;
case ALERT_SERVICE:
case STATE_SERVICE:
case STATE_SERVICE_INITIAL:
@@ -375,6 +383,7 @@ void TableStateHistory::answerQuery(Query *query)
case FLAPPING_SERVICE:
key = entry->_service;
is_service = true;
+ // TODO: Do we really want to fall through? If yes, add a comment, otherwise fix
it.
case ALERT_HOST:
case STATE_HOST:
case STATE_HOST_INITIAL:
@@ -689,6 +698,15 @@ int TableStateHistory::updateHostServiceState(Query *query, const
LogEntry *entr
switch (entry->_type)
{
+ case NONE:
+ case CORE_STARTING:
+ case CORE_STOPPING:
+ case LOG_VERSION:
+ case LOG_INITIAL_STATES:
+ case ACKNOWLEDGE_ALERT_HOST:
+ case ACKNOWLEDGE_ALERT_SERVICE:
+ // TODO: Check if a no-op is really the right thing to do here.
+ break;
case STATE_HOST:
case STATE_HOST_INITIAL:
case ALERT_HOST: