Module: check_mk
Branch: master
Commit: 8c7a726b22f2805943c077be7797901fdc35cec8
URL:
http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=8c7a726b22f280…
Author: Sven Panne <sp(a)mathias-kettner.de>
Date: Mon Jul 23 08:56:12 2018 +0200
Enabled too-many-ancestors and classified the remaining too-FOO-BAR warnings.
Change-Id: Ie1c67f5d3640cf936afdfb1dc7044476235e5229
---
tests/pylint/pylintrc | 30 ++++++++++++++++++------------
1 file changed, 18 insertions(+), 12 deletions(-)
diff --git a/tests/pylint/pylintrc b/tests/pylint/pylintrc
index eb7fea6..0f6834d 100644
--- a/tests/pylint/pylintrc
+++ b/tests/pylint/pylintrc
@@ -39,18 +39,6 @@ disable=
reimported,
relative-import,
singleton-comparison,
- too-few-public-methods,
- too-many-ancestors,
- too-many-arguments,
- too-many-boolean-expressions,
- too-many-branches,
- too-many-instance-attributes,
- too-many-lines,
- too-many-locals,
- too-many-nested-blocks,
- too-many-public-methods,
- too-many-return-statements,
- too-many-statements,
ungrouped-imports,
unidiomatic-typecheck,
unsubscriptable-object,
@@ -82,6 +70,10 @@ disable=
# duplication (introduce new classes, combine methods, etc.)
attribute-defined-outside-init,
#---------------------------------------------------------------------------
+ # We should enable this, at the moment it just means splitting up two
+ # gigantic functions.
+ too-many-branches,
+ #---------------------------------------------------------------------------
# Enabling these warnings would be nice, they are mostly a sign of sloppy
# programming practice. In some cases, they can even hide bugs.
bare-except,
@@ -92,6 +84,20 @@ disable=
# probably want to use "include-naming-hint=yes" in the BASIC section.
invalid-name,
#---------------------------------------------------------------------------
+ # Enabling these would be nice, but given the current state of affairs
+ # (gigantic modules with deeply nested humungous functions/methods), this
+ # will be a non-trivial amount of work.
+ too-few-public-methods,
+ too-many-arguments,
+ too-many-boolean-expressions,
+ too-many-instance-attributes,
+ too-many-lines,
+ too-many-locals,
+ too-many-nested-blocks,
+ too-many-public-methods,
+ too-many-return-statements,
+ too-many-statements,
+ #---------------------------------------------------------------------------
# The warnigns below will probably fixed by YAPF.
bad-continuation,
bad-indentation,