Module: check_mk Branch: master Commit: 98ca18ed30b9e049ecbacb5b0402322c74ebcf71 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=98ca18ed30b9e0… Author: Lars Michelsen &lt;lm(a)mathias-kettner.de&gt; Date: Fri Jan 16 08:42:33 2015 +0100 #1817 FIX The Check_MK service did not result in CRITICAL/WARNING states when using Nagios as core When using Nagios (or Icinga) as monitoring core, the "Check_MK" services was always resulting in an OK state, even when the output reported that it has a critical problem, for example because of the agent of the monitored host can not be reached. This bug seem to be existant since Mon, 15 Dec 2014. --- .werks/1817 | 14 ++++++++++++++ ChangeLog | 1 + modules/check_mk.py | 2 +- 3 files changed, 16 insertions(+), 1 deletion(-) diff --git a/.werks/1817 b/.werks/1817 new file mode 100644 index 0000000..27bddde --- /dev/null +++ b/.werks/1817 @@ -0,0 +1,14 @@ +Title: The Check_MK service did not result in CRITICAL/WARNING states when using Nagios as core +Level: 2 +Component: checks +Class: fix +Compatible: compat +State: unknown +Version: 1.2.7i1 +Date: 1421393931 + +When using Nagios (or Icinga) as monitoring core, the "Check_MK" services was always resulting +in an OK state, even when the output reported that it has a critical problem, for example +because of the agent of the monitored host can not be reached. + +This bug seem to be existant since Mon, 15 Dec 2014. diff --git a/ChangeLog b/ChangeLog index a9d8502..5a459fb 100644 --- a/ChangeLog +++ b/ChangeLog @@ -66,6 +66,7 @@ * 1809 FIX: cisco_temp_perf: Fixed exception when no temperature threshold provided by device * 1812 FIX: juniper_screenos_mem: Fixed too large memory reported (byte <> kbyte mixup) * 1814 FIX: agent_ibmsvc: Fixed missing executable flag + * 1817 FIX: The Check_MK service did not result in CRITICAL/WARNING states when using Nagios as core... Multisite: * 1758 Improved exception hander: Shows details without additional debug request, added mailto link for error report... diff --git a/modules/check_mk.py b/modules/check_mk.py index bf0dcc4..acfab986 100755 --- a/modules/check_mk.py +++ b/modules/check_mk.py @@ -2895,7 +2895,7 @@ no_inventory_possible = None # perform actual check with a general exception handler output.write("try:\n") - output.write(" do_check(%r, %r)\n" % (hostname, ipaddress)) + output.write(" sys.exit(do_check(%r, %r))\n" % (hostname, ipaddress)) output.write("except SystemExit, e:\n") output.write(" sys.exit(e.code)\n") output.write("except Exception, e:\n")