Module: check_mk Branch: master Commit: 598e5178f48ca900fa632b815ea948d4678fe698 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=598e5178f48ca9… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Thu Feb 2 10:58:17 2017 +0100 4316 FIX Views: Fixed editing of "hide from sidebar" and "show context button" options Change-Id: Ia822644dc7c6dd46317cab160c38cbb3d7354395 --- .werks/4316 | 9 +++++++++ ChangeLog | 2 ++ web/htdocs/visuals.py | 4 ++-- 3 files changed, 13 insertions(+), 2 deletions(-) diff --git a/.werks/4316 b/.werks/4316 new file mode 100644 index 0000000..af1bb02 --- /dev/null +++ b/.werks/4316 @@ -0,0 +1,9 @@ +Title: Views: Fixed editing of "hide from sidebar" and "show context button" options +Level: 1 +Component: multisite +Compatible: compat +Version: 1.4.0i4 +Date: 1486029473 +Class: fix + + diff --git a/ChangeLog b/ChangeLog index 8f5e1be..9af7101 100644 --- a/ChangeLog +++ b/ChangeLog @@ -105,6 +105,7 @@ * 4285 FIX: Availability: Timeline tables can now not be sorted and searched anymore * 4015 FIX: Multisite events page: Fixed slow page generation caused by the event delete icon... * 4315 FIX: Logwatch problematic logfiles list was showing too many logfiles + * 4316 FIX: Views: Fixed editing of "hide from sidebar" and "show context button" options WATO: * 4142 New extended search dialog for rulesets and rules... @@ -150,6 +151,7 @@ * 4188 snmp_extended_info: Now capable to inventorize cisco backplane chassis... * 4258 FIX: snmp_extended_info: fixed undefined variable + 1.4.0i3: Core & Setup: * 3978 FIX: mkbackup: Fixed backup to some CIFS shares ([Errno 13] Permission denied) '...')... diff --git a/web/htdocs/visuals.py b/web/htdocs/visuals.py index 04c6617..c202d99 100644 --- a/web/htdocs/visuals.py +++ b/web/htdocs/visuals.py @@ -653,11 +653,11 @@ def page_edit_visual(what, all_visuals, custom_field_handler = None, # appear as boolean-keys directly in the visual dict, but encapsulated # in a list choice in the value spec. visibility_elements = [ - ('hidden', FixedValue(None, + ('hidden', FixedValue(True, title = _('Hide this %s from the sidebar') % visual_type["title"], totext = "", )), - ('hidebutton', FixedValue(None, + ('hidebutton', FixedValue(True, title = _('Do not show a context button to this %s') % visual_type["title"], totext = "", )),