Branch: refs/heads/master
Home:
https://github.com/tribe29/checkmk
Commit: 61dcaf9925e3de63966638d81e02dfea6a3ac372
https://github.com/tribe29/checkmk/commit/61dcaf9925e3de63966638d81e02dfea6…
Author: Lars Michelsen <lm(a)tribe29.com>
Date: 2019-09-29 (Sun, 29 Sep 2019)
Changed paths:
M cmk/gui/valuespec.py
Log Message:
-----------
Cleanup TextOrRegExp class hierarchy
Change-Id: If52e1743988e9a365cc3f2fc3db802d36bc0b6d4
Commit: b2a4522c6f248e4c3a2d9252b42c988d073a2725
https://github.com/tribe29/checkmk/commit/b2a4522c6f248e4c3a2d9252b42c988d0…
Author: Lars Michelsen <lm(a)tribe29.com>
Date: 2019-09-29 (Sun, 29 Sep 2019)
Changed paths:
M cmk/gui/valuespec.py
M cmk/gui/visuals.py
Log Message:
-----------
ValueSpec: Cleanup custom validate handling
* Call the method without breaking the class hierarchy
* Made custom_validate an internal helper function
Change-Id: Ie638503d24f29829f941b51d505ce76d989f905f
Commit: 67b691ae1f71adae411c55b5104a039bb5cdddc8
https://github.com/tribe29/checkmk/commit/67b691ae1f71adae411c55b5104a039bb…
Author: Lars Michelsen <lm(a)tribe29.com>
Date: 2019-09-29 (Sun, 29 Sep 2019)
Changed paths:
M cmk/gui/plugins/wato/utils/__init__.py
M cmk/gui/valuespec.py
M cmk/gui/visuals.py
M cmk/gui/wato/mkeventd.py
M cmk/gui/watolib/host_attributes.py
M cmk/gui/watolib/rulespecs.py
Log Message:
-----------
Cleanup valuespec validation methods
* Untied validate_value and custom_validate logic
The custom_validation method (provided via constructor argument
validate=func) was mostly called by the validate_value method. The
problem was that validate_value method was often overridden for
implementing valuespec type specific validations. It often happened that
these specific validate_values forgot to call the custom_validate
method.
The type specific validations now need to be implemented by overriding
_validate_value method.
* Simplify validation logic
The validate_value method is still the one to be called from external
for validating values. But instead of just performing a part of the
validations it now executes all 3 phases of the validation:
1. validate_datatype : Ensure the python data type is as expected
2. _validate_value : Valuespec type specific validations
3. _custom_validate : instance specific validations
Especially the first validation was missing in many situations.
Todo: The validate_datatype call is disabled for the moment, until the
str/unicode issue is solved (see TODO in ValueSpec.validate_value).
Change-Id: Ib45302ea1f5389601d0bb06598e9df85a0289efa
Commit: 8f99e016c907a7534d1bbf64604aed86392ca5bb
https://github.com/tribe29/checkmk/commit/8f99e016c907a7534d1bbf64604aed863…
Author: Lars Michelsen <lm(a)tribe29.com>
Date: 2019-09-29 (Sun, 29 Sep 2019)
Changed paths:
M cmk/gui/valuespec.py
Log Message:
-----------
Change class description comments to docstrings
Change-Id: I711f5dcb891d8ae3adfb1fa97622d51c1dc0a316
Commit: 8806b9579c7a793c6b80c7c6f89bf7a912da37f8
https://github.com/tribe29/checkmk/commit/8806b9579c7a793c6b80c7c6f89bf7a91…
Author: Lars Michelsen <lm(a)tribe29.com>
Date: 2019-09-29 (Sun, 29 Sep 2019)
Changed paths:
M cmk/gui/valuespec.py
Log Message:
-----------
Cleanup classes: Use super for calling parent methods
Change-Id: I65b1256fbf0f1f01b8c1f344f6c211d4653b84f8
Compare:
https://github.com/tribe29/checkmk/compare/0902919c7833...8806b9579c7a