Module: check_mk Branch: master Commit: f4d850a7577686eacabef0e2e94163cb39a18fb1 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=f4d850a7577686… Author: Andreas Boesl <ab(a)mathias-kettner.de> Date: Fri Mar 24 11:28:52 2017 +0100 4463 FIX f5_bigip_cluster_status: fixed invalid evaluation of node states when this check runs on a cluster Change-Id: Ib07fd38ee581f149918217fdc8780d6858945f1d --- .werks/4463 | 10 ++++++++++ checks/f5_bigip_cluster_status | 4 ++-- 2 files changed, 12 insertions(+), 2 deletions(-) diff --git a/.werks/4463 b/.werks/4463 new file mode 100644 index 0000000..e32fc54 --- /dev/null +++ b/.werks/4463 @@ -0,0 +1,10 @@ +Title: f5_bigip_cluster_status: fixed invalid evaluation of node states when this check runs on a cluster +Level: 1 +Component: checks +Compatible: compat +Edition: cee +Version: 1.5.0i1 +Date: 1490351215 +Class: fix + + diff --git a/checks/f5_bigip_cluster_status b/checks/f5_bigip_cluster_status index 1d7d83f..d857c76 100644 --- a/checks/f5_bigip_cluster_status +++ b/checks/f5_bigip_cluster_status @@ -63,10 +63,10 @@ def inventory_f5_bigip_cluster_status(parsed): def check_f5_bigip_cluster_status(_no_item, params, parsed, is_v11_2 = False): if is_v11_2: node_states = ["unknown", "offline", "forced offline", "standby", "active"] - active_value = 4 + active_value = "4" else: node_states = ["standby", "active 1", "active 2", "active"] - active_value = 3 + active_value = "3" if params["type"] == "active_standby" and parsed.values().count(active_value) > 1: yield 2, "More than 1 node is active: "