Branch: refs/heads/master
Home:
https://github.com/Checkmk/checkmk
Commit: 7c486199af9627a7128d8098a29b796c287d0e53
https://github.com/Checkmk/checkmk/commit/7c486199af9627a7128d8098a29b796c2…
Author: Dhananjay Shah <dhananjay.shah(a)checkmk.com>
Date: 2024-07-09 (Tue, 09 Jul 2024)
Changed paths:
M tests/gui_e2e/conftest.py
M tests/gui_e2e/test_asvs.py
M tests/gui_e2e/test_login.py
M tests/gui_e2e/test_mobile.py
M tests/gui_e2e/test_sidebar.py
M tests/testlib/playwright/plugin.py
M tests/testlib/playwright/pom/dashboard.py
Log Message:
-----------
gui-e2e: re-structure code within framework
Enable logging-in into Checkmk site only once per test-module.
+ new fixtures
`testlib.playwright.plugin`
+ session-scoped `context_kwargs`
+ function-scoped `page_mobile`, complementing `page`
`tests.gui_e2e.conftest`
+ function-scoped `dashboard_page_mobile`, complementing `dashboard_page`
new PoM added `DashboardMobile`
+ function-scoped `new_browser_context_and_page`
+ scope changes in fixtures
function > module and prefixing `_` to signify internal usage.
+ `context` and `context_mobile`
+ `logged_in_page` and `logged_in_page_mobile`
+ code sanitization
+ encapsulated code within fixtures `context` and `page`
encapsulated code can be used as python-contexts, as well.
+ move code from `context` into `pages`
+ `mobile_device` parameer is not required in `conftest._log_in`.
+ remove `pytestconfig` as argument when `request` is used
`pytestconfig` is the same as `request.config`.
+ update corresponding test-cases to retain test-design.
CMK-17884
Change-Id: Ie13f7bbfe09f42b724b3fa687f5d2434dd23389a
To unsubscribe from these emails, change your notification settings at
https://github.com/Checkmk/checkmk/settings/notifications