Module: check_mk
Branch: master
Commit: 86ceec68b9a544a059712ed8ec65525a703fcd2e
URL:
http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=86ceec68b9a544…
Author: Mathias Kettner <mk(a)mathias-kettner.de>
Date: Tue Feb 3 12:11:26 2015 +0100
#1827 oracle_tablespace: WATO rule for default increment
The WATO rule missed a configuration for default incremente on datafiles.
This has been added.
Importan Note:
The old configuration variable oracle_tablespaces_check_default_increment
has been replaced with the dictionary based parameter defaultincrement.
The default behaivor is still true and only users who disabled the check
for default increment need to add a rule with the new dictionary based
parameter.
---
.werks/1827 | 19 +++++++++++++++++++
ChangeLog | 2 ++
checks/oracle_tablespaces | 7 ++++---
web/plugins/wato/check_parameters.py | 5 +++++
4 files changed, 30 insertions(+), 3 deletions(-)
diff --git a/.werks/1827 b/.werks/1827
new file mode 100644
index 0000000..bd8b107
--- /dev/null
+++ b/.werks/1827
@@ -0,0 +1,19 @@
+Title: oracle_tablespace: WATO rule for default increment
+Level: 1
+Component: checks
+Class: feature
+Compatible: incomp
+State: unknown
+Version: 1.2.7i1
+Date: 1422393240
+
+The WATO rule missed a configuration for default incremente on datafiles.
+This has been added.
+
+Importan Note:
+The old configuration variable oracle_tablespaces_check_default_increment
+has been replaced with the dictionary based parameter defaultincrement.
+The default behaivor is still true and only users who disabled the check
+for default increment need to add a rule with the new dictionary based
+parameter.
+
diff --git a/ChangeLog b/ChangeLog
index d413469..d86fae8 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -60,6 +60,8 @@
* 1216 hp_procurve_cpu: Can now be configured with Wato
* 1676 if.include: now able to detect grouped interfaces...
* 1928 netapp_api_if: Improved handling and check output of virtual interfaces...
+ * 1827 oracle_tablespace: WATO rule for default increment...
+ NOTE: Please refer to the migration notes!
* 1217 dell_om_sensors: Check now uses generic temperature features...
NOTE: Please refer to the migration notes!
* 1929 netapp_api_if: improved inventory and check output of virtual interfaces...
diff --git a/checks/oracle_tablespaces b/checks/oracle_tablespaces
index 48e041e..8cb4e85 100644
--- a/checks/oracle_tablespaces
+++ b/checks/oracle_tablespaces
@@ -65,12 +65,14 @@ factory_settings["oracle_tablespaces_defaults"] = {
"levels" : (10.0, 5.0),
"magic_normsize" : 1000,
"magic_maxlevels": (60.0, 50.0),
+ "defaultincrement": True,
}
# Whether to check auto extend settings
oracle_tablespaces_check_autoext = True
-# Whether to check default increment size
+# this parameter is deprecated and needed for old configurations with
+# parameter in main.mk. It is not used anymore!
oracle_tablespaces_check_default_increment = True
def inventory_oracle_tablespaces(info):
@@ -242,7 +244,7 @@ def check_oracle_tablespaces(item, params, info):
status = 0
# Check increment size, should not be set to default (1)
- if oracle_tablespaces_check_default_increment:
+ if params.get("defaultincrement"):
if uses_default_increment:
infotext += ", DEFAULT INCREMENT(!)"
status = 1
@@ -290,4 +292,3 @@ check_info['oracle_tablespaces'] = {
"default_levels_variable" : "oracle_tablespaces_defaults",
"includes" : [ "oracle.include" ]
}
-check_config_variables.append("oracle_tablespaces_check_default_increment")
diff --git a/web/plugins/wato/check_parameters.py b/web/plugins/wato/check_parameters.py
index 04c5eeb..637c6f6 100644
--- a/web/plugins/wato/check_parameters.py
+++ b/web/plugins/wato/check_parameters.py
@@ -3624,6 +3624,11 @@ register_check_parameters(
title = _("Autoextend"),
label = _("Autoextension is expected"),
help = "")),
+ ( "defaultincrement",
+ Checkbox(
+ title = _("Detault Increment"),
+ label = _("State is WARNING in case of next extent is
default."),
+ help = "")),
]),
TextAscii(
title = _("Explicit tablespaces"),