Branch: refs/heads/master Home: https://github.com/Checkmk/checkmk Commit: 7d8962378bcaece44343aeccb6eeaad0ea011afe https://github.com/Checkmk/checkmk/commit/7d8962378bcaece44343aeccb6eeaad0e… Author: Sven Panne <sven.panne(a)checkmk.com> Date: 2023-10-24 (Tue, 24 Oct 2023) Changed paths: M cmk/ec/history.py M cmk/ec/main.py M tests/unit/cmk/ec/test_ec_event_server.py Log Message: ----------- Removed History.reload_config(). This makes History's config immutable, so it enables us to use further refactorings, e.g. "Replace type code with subclasses": https://refactoring.com/catalog/replaceTypeCodeWithSubclasses.html Change-Id: I056738d062a605d724d73e1756453d08a932ffbe Commit: 45687a8710a9dfbff2692dc88c5c0f19f8311d9e https://github.com/Checkmk/checkmk/commit/45687a8710a9dfbff2692dc88c5c0f19f… Author: Sven Panne <sven.panne(a)checkmk.com> Date: 2023-10-24 (Tue, 24 Oct 2023) Changed paths: M cmk/ec/history.py M cmk/ec/main.py M tests/unit/cmk/ec/conftest.py M tests/unit/cmk/ec/test_ec_event_server.py Log Message: ----------- Replace History's type code with subclasses. This enables us to use "replace conditionals with polymorphism", i.e. nuke the archive mode conditionals from History by moving the relevant code to the subclasses. Change-Id: I7f24b16338dfca40fbad64dc947215e23a4e9a36 Commit: 4e919d19c74f879a9008111db158bf686941b957 https://github.com/Checkmk/checkmk/commit/4e919d19c74f879a9008111db158bf686… Author: Sven Panne <sven.panne(a)checkmk.com> Date: 2023-10-24 (Tue, 24 Oct 2023) Changed paths: M cmk/ec/history.py Log Message: ----------- Replace conditionals with polymorphism. The actual dispatching is now done by Pyhton, not by us. :-) Change-Id: I4dffc6c0aaf875450185a874fdcec4855ad4eecc Commit: 3a991acca9047ead132e34dcffa86bb8f170fb78 https://github.com/Checkmk/checkmk/commit/3a991acca9047ead132e34dcffa86bb8f… Author: Sven Panne <sven.panne(a)checkmk.com> Date: 2023-10-24 (Tue, 24 Oct 2023) Changed paths: M cmk/ec/history.py M tests/unit/cmk/ec/conftest.py M tests/unit/cmk/ec/test_ec_history_file.py Log Message: ----------- Pushed down History constructor to subclasses. This enables us to clean up instance fields later, improves typing at various places, and completely removes the need for the type code. Change-Id: If9598bd94140f271fe5994fd4e7f949385bd7b4e Compare: https://github.com/Checkmk/checkmk/compare/fce9c4d6e05e...3a991acca904