Module: check_mk
Branch: master
Commit: a48ee8e59b95a998c1407d922db3c6f891f054cd
URL:
http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=a48ee8e59b95a9…
Author: Jukka Aro <ja(a)mathias-kettner.de>
Date: Thu Sep 21 16:51:24 2017 +0200
Refactor the processing of Windows eventlog
Key changes:
* Extract the actual processing (done twice!) in a separate function.
* Use functions in anonymous namespace for functionality that does
not need to access class members.
* Improve readability:
* Rename functions and variables to make them more descriptive.
* Favour pass-by-value function parameters and real return values
over output reference parameters with void return value.
* Favour std::unique_ptr over std::shared_ptr (make explicit who
owns an object).
Change-Id: I7db5ee676c80bd4f4a695f9401104420ac69acf0
---
agents/windows/EventLog.cc | 7 +-
agents/windows/EventLog.h | 2 +-
agents/windows/EventLogVista.cc | 6 +-
agents/windows/EventLogVista.h | 2 +-
agents/windows/IEventLog.h | 2 +-
agents/windows/build_version | 2 +-
agents/windows/check_mk_agent-64.exe | Bin 1564160 -> 1563648 bytes
agents/windows/check_mk_agent-64.unstripped.exe | Bin 22765638 -> 22700573 bytes
agents/windows/check_mk_agent-64.unversioned.exe | Bin 1564160 -> 1563648 bytes
agents/windows/check_mk_agent.exe | Bin 1547264 -> 1546752 bytes
agents/windows/check_mk_agent.msi | Bin 3385344 -> 3384320 bytes
agents/windows/check_mk_agent.unstripped.exe | Bin 19613197 -> 19551772 bytes
agents/windows/check_mk_agent.unversioned.exe | Bin 1547264 -> 1546752 bytes
agents/windows/crash.exe | Bin 358864 -> 358864 bytes
agents/windows/install_agent-64.exe | Bin 681081 -> 680694 bytes
agents/windows/install_agent.exe | Bin 675979 -> 675746 bytes
agents/windows/nowin.exe | Bin 361000 -> 361000 bytes
agents/windows/plugins/mk_jolokia.exe | Bin 10106814 -> 10106814 bytes
agents/windows/sections/SectionEventlog.cc | 106 ++++++++++++-----------
agents/windows/sections/SectionEventlog.h | 8 +-
20 files changed, 70 insertions(+), 65 deletions(-)
Diff:
http://git.mathias-kettner.de/git/?p=check_mk.git;a=commitdiff;h=a48ee8e59b…