Branch: refs/heads/master
Home:
https://github.com/tribe29/checkmk
Commit: d7784cd1de58b6d0656273eeaf59a96329faa95c
https://github.com/tribe29/checkmk/commit/d7784cd1de58b6d0656273eeaf59a9632…
Author: Sven Panne <sven.panne(a)tribe29.com>
Date: 2020-04-23 (Thu, 23 Apr 2020)
Changed paths:
M cmk/base/snmp.py
Log Message:
-----------
Reduce cyclomatic complexity
Now, we clearly see that there are three cache modes: no cache, write
cache, and read/write cache.
CMK-4244
Change-Id: I2417ce252f227bf8a4c3cbd978b20e24cfa66f7b
Commit: 412de1e32db3b9d2aac899ce0cc9a5febd20dcba
https://github.com/tribe29/checkmk/commit/412de1e32db3b9d2aac899ce0cc9a5feb…
Author: Mathias Laurin <mathias.laurin(a)tribe29.com>
Date: 2020-04-23 (Thu, 23 Apr 2020)
Changed paths:
M cmk/base/snmp.py
M tests-py3/unit/cmk/base/test_snmp_unit.py
Log Message:
-----------
snmp: Name special columns
This eases testing.
Change-Id: Iba05822f385598097fa4bbd57179543e7e60e3d4
Commit: 7437037841728ca8715de91ef4ce39bd50d46fa5
https://github.com/tribe29/checkmk/commit/7437037841728ca8715de91ef4ce39bd5…
Author: Mathias Laurin <mathias.laurin(a)tribe29.com>
Date: 2020-04-23 (Thu, 23 Apr 2020)
Changed paths:
M cmk/base/snmp.py
Log Message:
-----------
Remove temporaries and more explicit logic
- remove two unnecessary temporaries
- separate intendence from the business logic
Decrease the size of `get_snmp_table()` #4
CMK-4244
Change-Id: I2d7649a90e56bd771e3972126b6270701258d8d6
Commit: b92e0d4ed4c921e554e1ac7eecb455b16d3bc44a
https://github.com/tribe29/checkmk/commit/b92e0d4ed4c921e554e1ac7eecb455b16…
Author: Mathias Laurin <mathias.laurin(a)tribe29.com>
Date: 2020-04-23 (Thu, 23 Apr 2020)
Changed paths:
M cmk/base/snmp.py
Log Message:
-----------
Let `_get_snmpwalk` return rowinfo in any case
Before, some columns were special-cased before the call and once more in
the function. The function now handles every column types.
CMK-4244
Change-Id: I43ae9ee80f79f35a615060f5e57df4df6933604d
Commit: 56e70db92c4646c2b356bafa8af84f4dd3748675
https://github.com/tribe29/checkmk/commit/56e70db92c4646c2b356bafa8af84f4dd…
Author: Mathias Laurin <mathias.laurin(a)tribe29.com>
Date: 2020-04-23 (Thu, 23 Apr 2020)
Changed paths:
M tests-py3/unit/cmk/base/data_sources/test_snmp_data_source.py
Log Message:
-----------
Test SNMP DS execute method
CMK-4244
Change-Id: Ie4648eb82996ea958b679769595f93ef8fbeff75
Commit: 5fbc5a7ccfcaa07a8c373c8bbf63a545a4007dad
https://github.com/tribe29/checkmk/commit/5fbc5a7ccfcaa07a8c373c8bbf63a545a…
Author: Mathias Laurin <mathias.laurin(a)tribe29.com>
Date: 2020-04-23 (Thu, 23 Apr 2020)
Changed paths:
M cmk/base/data_sources/snmp.py
Log Message:
-----------
SNMP DS: Sort names first
The fetcher should take the sorted list.
CMK-4244
Change-Id: I50c04ff55c8c7cd50606e77b9286452ed42dd0d7
Commit: 9837c9ed9dafbe03adece5fcc3a6eb7af4d61db4
https://github.com/tribe29/checkmk/commit/9837c9ed9dafbe03adece5fcc3a6eb7af…
Author: Mathias Laurin <mathias.laurin(a)tribe29.com>
Date: 2020-04-23 (Thu, 23 Apr 2020)
Changed paths:
M cmk/base/data_sources/snmp.py
Log Message:
-----------
SNMP: Make static raw data fetcher
CMK-4244
Change-Id: I326c9d59faee9abd92ad1395bb9026fb6f463382
Commit: 682c5e28534abe8b03c78886f88910709ffa7e31
https://github.com/tribe29/checkmk/commit/682c5e28534abe8b03c78886f88910709…
Author: Mathias Laurin <mathias.laurin(a)tribe29.com>
Date: 2020-04-23 (Thu, 23 Apr 2020)
Changed paths:
M cmk/base/data_sources/snmp.py
Log Message:
-----------
Extract SNMPDataFetcher
To do: There is no need to instantiate if the data is readily available
from the cache.
CMK-4244
Change-Id: I7e4011d3a04632e02f4b31779e86c7f310331a38
Commit: 974c35048eca9aaefa75e2b72962241452594415
https://github.com/tribe29/checkmk/commit/974c35048eca9aaefa75e2b7296224145…
Author: Mathias Laurin <mathias.laurin(a)tribe29.com>
Date: 2020-04-23 (Thu, 23 Apr 2020)
Changed paths:
M cmk/base/data_sources/snmp.py
Log Message:
-----------
Simplify SNMP data fetcher
This patch simplifies the SNMP data fetcher by precomputing the elements
[name : str, oid_info : OIDInfo] of the loop.
- The fetcher needs less attributes.
- The fetcher does not need to load the inventory plugins anymore.
CMK-4218
Change-Id: Ieb1097720bc7c07f90549b1d018fc2c30a0e3695
Compare:
https://github.com/tribe29/checkmk/compare/0a06ab083d77...974c35048eca