Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: dbb2c34b0831e76c111c3947acbcf9ccb5049bdf https://github.com/tribe29/checkmk/commit/dbb2c34b0831e76c111c3947acbcf9ccb… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2020-10-27 (Tue, 27 Oct 2020) Changed paths: M cmk/base/checkers/_checkers.py M cmk/base/checking.py M cmk/base/discovery.py M cmk/base/inventory.py M tests/unit/cmk/base/checkers/test_host_sections.py Log Message: ----------- Fix update_host_sections type `Optional[Sequence]` is a code smell and introduces an actual bug in `update_host_sections`, where `fetcher_messages: Optional[Sequence] = None` triggers an unwanted call to `Fetcher.fetch()`. We therefore change the type of from `Optional[Sequence]` to `Sequence` and track and fix the call sites. CMK-5815 Change-Id: I871afb325680b59af60604a3cb99191d940d6bb7 Commit: 9d4984a35c9e95f411ae73f552bd4b989bf1419b https://github.com/tribe29/checkmk/commit/9d4984a35c9e95f411ae73f552bd4b989… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2020-10-27 (Tue, 27 Oct 2020) Changed paths: M cmk/base/checking.py M cmk/base/discovery.py M cmk/base/modes/check_mk.py Log Message: ----------- Improve consistency btw `do_check` and `check_discovery` Both functions may be used interchangeably in parts of our code, such as in the DiscoCheckExecutor so that the added consistency helps to avoid bugs. Moreover, the last two arguments to `do_check()` are optional sequences so that swapping them may remain undetected by the type checker. Making them keyword only fixes this issue. CMK-5815 Change-Id: I65507f39d42d0aab30c1bfff32c65cffbc465705 Compare: https://github.com/tribe29/checkmk/compare/1d4f2bee4895...9d4984a35c9e