Module: check_mk
Branch: master
Commit: 33d0f7ae4701d1149a4f39f557dc2121fcb604e8
URL:
http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=33d0f7ae4701d1…
Author: Lars Michelsen <lm(a)mathias-kettner.de>
Date: Fri Feb 25 11:23:35 2011 +0100
validate_checks: Added linelength check
---
doc/helpers/validate_checks | 37 +++++++++++++++++++++++++++----------
1 files changed, 27 insertions(+), 10 deletions(-)
diff --git a/doc/helpers/validate_checks b/doc/helpers/validate_checks
index 8f6590a..68bba37 100755
--- a/doc/helpers/validate_checks
+++ b/doc/helpers/validate_checks
@@ -147,20 +147,33 @@ for check in get_checks():
global_vars[check] += [ name ]
SCORE_START = 10
+
C_OK = 1
C_FAILED = 2
C_INVALID = 3
-TESTS = { 'manpage': C_OK,
- 'snmp_scan': C_OK,
- 'pnp_tmpl': C_OK,
- 'pnp_rra': C_OK,
- 'snmp_scan': C_OK,
- 'reindent': C_OK,
- 'global_vars': C_OK,
+
+LINELENGTH_LIMIT = 100
+
+TESTS = {
+ 'manpage': C_OK,
+ 'snmp_scan': C_OK,
+ 'pnp_tmpl': C_OK,
+ 'pnp_rra': C_OK,
+ 'snmp_scan': C_OK,
+ 'reindent': C_OK,
+ 'global_vars': C_OK,
+ 'linelength': C_OK,
+}
+
+WEIGHT = {
+ 'manpage': 2,
+ 'global_vars': 2,
+ 'reindent': 2,
+ 'linelength': 2,
}
-WEIGHT = { 'manpage': 2, 'global_vars': 2, 'reindent': 2 }
-manpage = {}
+manpage = {}
+checkfiles = {}
# #############################################################################
# Check definitions
@@ -221,7 +234,11 @@ def is_valid_linelength(check):
return True
def verify_linelength(check):
-
+ """ Read the checkfile and compare all lines with the maximum line
length """
+ for line in get_checkfile(check).split("\n"):
+ if len(line) > LINELENGTH_LIMIT:
+ return False
+ return True
# Manpage:
# - Does the check have a manpage?