[checkmk-commits] [tribe29/checkmk] e5f826: Do not delay construction of summary

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: e5f8262a1e11aced03dfb2866d68e98f748488d6 https://github.com/tribe29/checkmk/commit/e5f8262a1e11aced03dfb2866d68e98f7… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2020-04-07 (Tue, 07 Apr 2020) Changed paths: M cmk/base/data_sources/piggyback.py Log Message: ----------- Do not delay construction of summary The set is filled in the fetcher and used in the helper. This would imply passing it back from the fetcher and, therefore, some sort of serialization. This can be avoided by getting rid of the intermediate structure. Indeed, delaying the construction of the ServiceCheckResult is not necessary: the intermediate values kept in the set are never used by themselves. CMK-4143 Change-Id: I795baf0654d4a7d8c89d0878aacbfe6ee0530ea7 Commit: ae8386fecbefb620df4180ceb84bdc765d59f86b https://github.com/tribe29/checkmk/commit/ae8386fecbefb620df4180ceb84bdc765… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2020-04-07 (Tue, 07 Apr 2020) Changed paths: M cmk/base/data_sources/piggyback.py Log Message: ----------- Make fetching methods static in piggyback source CMK-4143 Change-Id: Ic8fd7a2cc2c48337fb43322e4395d12bbd075755 Commit: c1c6848d6324cc4895d8da9558b12042af03280e https://github.com/tribe29/checkmk/commit/c1c6848d6324cc4895d8da9558b12042a… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2020-04-07 (Tue, 07 Apr 2020) Changed paths: M cmk/base/data_sources/piggyback.py Log Message: ----------- Improve code structure - Split the logic into functions working at the same abstraction level, that is, make the code more procedural and better structured - Improve consistency of the arguments passed to the functions CMK-4143 Change-Id: I20dfb9fe38a368ca272e821ffd4e792a928c5a5b Commit: c6d54b4983300dde1a28e0e982d564777660b149 https://github.com/tribe29/checkmk/commit/c6d54b4983300dde1a28e0e982d564777… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2020-04-07 (Tue, 07 Apr 2020) Changed paths: M cmk/base/data_sources/piggyback.py M tests-py3/unit/cmk/base/data_sources/test_piggy_back_data_source.py Log Message: ----------- Extract PiggyBackDataFetcher CMK-4143 Change-Id: Iba20f472f40182f35c7f425d2a08b6b0a9b402f7 Compare: https://github.com/tribe29/checkmk/compare/7da24912efe5...c6d54b498330