[checkmk-commits] [tribe29/checkmk] 0b2fc3: Remove gratuitous type aliases

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 0b2fc3a7fdce77fbe10528f263d224d4287f01da https://github.com/tribe29/checkmk/commit/0b2fc3a7fdce77fbe10528f263d224d42… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2023-04-06 (Thu, 06 Apr 2023) Changed paths: M cmk/base/config.py M cmk/bi/lib.py M cmk/bi/searcher.py M cmk/gui/view_utils.py M cmk/gui/views/painter/v0/helpers.py M cmk/gui/wato/pages/rulesets.py M cmk/gui/watolib/host_attributes.py M cmk/gui/watolib/hosts_and_folders.py M cmk/gui/watolib/rulesets.py M cmk/utils/rulesets/ruleset_matcher.py M cmk/utils/store/host_storage.py M cmk/utils/tags.py M tests/unit/cmk/base/test_core_config.py M tests/unit/cmk/utils/test_utils_tags.py Log Message: ----------- Remove gratuitous type aliases Such type aliases have disadvantages such as: * They may introduce unnecessary coupling between modules (here with `ruleset_matcher`). * They obscure the signature of the functions by masking the fact that some types depend on each other, or hiding simple transformations (such as `Mapping[k, v] -> Mapping[v, k]`, for example). * They are not as flexible regarding variance and mutability: One would tend to always use the alias instead of, for example, returning a Sequence[T] and taking an Iterator[T]. See also: * https://wiki.haskell.org/Fairbairn_threshold Change-Id: I1545dc523e48df239fc7e5b3605fe15f5f08db6a Commit: cf0c5c593e8c119c2f47ed0afbe034377ce95355 https://github.com/tribe29/checkmk/commit/cf0c5c593e8c119c2f47ed0afbe034377… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2023-04-06 (Thu, 06 Apr 2023) Changed paths: M cmk/utils/rulesets/ruleset_matcher.py Log Message: ----------- Type a few Any in the ruleset matcher Change-Id: I1bd69ad4bb7e01b4ff3a461f83997fc6855dbe1d Compare: https://github.com/tribe29/checkmk/compare/3dc6bedb7761...cf0c5c593e8c