10 Jun
2020
10 Jun
'20
12:02 p.m.
Branch: refs/heads/master
Home: https://github.com/tribe29/checkmk
Commit: c705449fcb652f6486e432b5cb4ae72eabb22a89
https://github.com/tribe29/checkmk/commit/c705449fcb652f6486e432b5cb4ae72ea…
Author: Mathias Laurin <mathias.laurin(a)tribe29.com>
Date: 2020-06-10 (Wed, 10 Jun 2020)
Changed paths:
M .isort.cfg
M cmk/base/api/agent_based/register/export.py
M cmk/base/api/agent_based/register/section_plugins.py
M cmk/base/api/agent_based/register/section_plugins_legacy.py
M cmk/base/api/agent_based/section_types.py
M cmk/base/api/agent_based/utils.py
M cmk/base/automations/check_mk.py
M cmk/base/check_api.py
M cmk/base/check_utils.py
M cmk/base/config.py
M cmk/base/data_sources/snmp.py
M cmk/base/inventory.py
M cmk/base/modes/check_mk.py
M cmk/base/plugins/agent_based/agent_based_api/v0/__init__.py
R cmk/base/snmp.py
M cmk/base/snmp_scan.py
M cmk/base/snmp_utils.py
M cmk/fetchers/factory.py
M cmk/fetchers/snmp.py
M cmk/fetchers/snmp_backend/_utils.py
M cmk/fetchers/snmp_backend/classic.py
M cmk/fetchers/snmp_backend/stored_walk.py
A cmk/lib/__init__.py
A cmk/lib/snmplib/__init__.py
A cmk/lib/snmplib/snmp_cache.py
A cmk/lib/snmplib/snmp_modes.py
A cmk/lib/snmplib/snmp_table.py
A cmk/lib/snmplib/type_defs.py
R cmk/utils/snmp_cache.py
R cmk/utils/snmp_table.py
M cmk/utils/type_defs.py
R tests-py3/integration/cmk/base/snmp/snmp_data/1.3.6.1.6.1.1.0.snmprec
R tests-py3/integration/cmk/base/snmp/snmp_data/1.3.6.1.6.1.1.0/127.0.0.1.snmprec
R tests-py3/integration/cmk/base/snmp/snmp_data/cmk-walk/localhost
R tests-py3/integration/cmk/base/snmp/snmp_data/public.snmprec
R tests-py3/integration/cmk/base/snmp/test_snmp.py
A tests-py3/integration/cmk/lib/snmplib/conftest.py
A tests-py3/integration/cmk/lib/snmplib/snmp_data/1.3.6.1.6.1.1.0.snmprec
A tests-py3/integration/cmk/lib/snmplib/snmp_data/1.3.6.1.6.1.1.0/127.0.0.1.snmprec
A tests-py3/integration/cmk/lib/snmplib/snmp_data/cmk-walk/localhost
A tests-py3/integration/cmk/lib/snmplib/snmp_data/public.snmprec
A tests-py3/integration/cmk/lib/snmplib/test_snmp_modes.py
A tests-py3/integration/cmk/lib/snmplib/test_snmp_table.py
R tests-py3/integration/cmk/utils/test_snmp_table.py
M tests-py3/testlib/pylint_checker_cmk_module_layers.py
M tests-py3/unit/cmk/base/api/agent_based/register/test_section_plugins.py
M
tests-py3/unit/cmk/base/api/agent_based/register/test_section_plugins_legacy_snmp_tree.py
M tests-py3/unit/cmk/base/api/agent_based/test_section_types.py
M tests-py3/unit/cmk/base/data_sources/test_snmp_data_source.py
M tests-py3/unit/cmk/base/test_check_api.py
M tests-py3/unit/cmk/base/test_snmp_scan.py
M tests-py3/unit/cmk/base/test_snmp_utils.py
M tests-py3/unit/cmk/fetchers/test_classic_snmp.py
A tests-py3/unit/cmk/lib/test_snmplib_snmp_table.py
R tests-py3/unit/cmk/utils/test_snmp_table_unit.py
M tests-py3/unit/cmk/utils/test_type_defs.py
Log Message:
-----------
Move SNMP functions together
This has several advantages:
* We move more code out of `cmk.utils` than we put in.
* We group related stuff.
* The new `snmplib` package is highly cohesive.
* There is a clear separation in `type_defs` between SNMP
types and the non-SNMP types.
The higher cohesion allows us to avoid copy and pasting fixtures in
SNMP tests.
This also clarifies user code in that SNMP-related stuff now has to
come from `snmplib`.
The `lib` namespace is consistent with our other top-level
namespaces `base`, `utils`, etc. It is otherwise useless.
CMK-4610
Change-Id: Ifa55d5dbd89fc337b255d8d9555526e1bfdaf0e7