[checkmk-commits] added WK7253: No longer query data for disabled snmp checks

Module: check_mk Branch: master Commit: a4e56c2ec6f2ad50a33527d28913e7cf53f2e3f9 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=a4e56c2ec6f2ad… Author: Andreas Boesl <ab(a)mathias-kettner.de> Date: Thu Apr 4 15:28:16 2019 +0200 added WK7253: No longer query data for disabled snmp checks Change-Id: Iae2ae8131b32ec13b1e4b15dc36eccf3694f67a5 --- .werks/7253 | 13 +++++++++++++ cmk_base/snmp_scan.py | 2 +- 2 files changed, 14 insertions(+), 1 deletion(-) diff --git a/.werks/7253 b/.werks/7253 new file mode 100644 index 0000000..04cb81f --- /dev/null +++ b/.werks/7253 @@ -0,0 +1,13 @@ +Title: Service Discovery: No longer query data for disabled snmp checks +Level: 1 +Component: checks +Class: fix +Compatible: compat +Edition: cre +State: unknown +Version: 1.6.0i1 +Date: 1553769555 + +Even if a snmp check type was disabled, its relevant data was still queried from the host and discarded shortly after. +This has been fixed. + diff --git a/cmk_base/snmp_scan.py b/cmk_base/snmp_scan.py index 6a2495e..659da17 100644 --- a/cmk_base/snmp_scan.py +++ b/cmk_base/snmp_scan.py @@ -101,7 +101,7 @@ def _snmp_scan(host_config, default_found = [] for check_plugin_name, _unused_check in items: - if check_plugin_name in config.ignored_checktypes: + if config.service_ignored(hostname, check_plugin_name, None): continue else: if for_inv and not inventory_plugins.is_snmp_plugin(check_plugin_name):