[checkmk-commits] [tribe29/checkmk] c6b0b6: pylint_checker_cmk_module_layers: add tests

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: c6b0b680de184e25e22d5cbab0006791e77fa3f7 https://github.com/tribe29/checkmk/commit/c6b0b680de184e25e22d5cbab0006791e… Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com> Date: 2020-10-06 (Tue, 06 Oct 2020) Changed paths: A tests/unit/test_pylint_checker_cmk_module_layers.py Log Message: ----------- pylint_checker_cmk_module_layers: add tests Change-Id: Ib5b9473eba38edadcc9ac38f7ce0e6f83b22e3b8 Commit: 37d883d87772642fab4c01bf56a27f5fd47ea867 https://github.com/tribe29/checkmk/commit/37d883d87772642fab4c01bf56a27f5fd… Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com> Date: 2020-10-06 (Tue, 06 Oct 2020) Changed paths: M tests/testlib/pylint_checker_cmk_module_layers.py Log Message: ----------- pylint_checker_cmk_module_layers: remove dead code The function _is_import_in_cee_component_part will allways be false, if reached. Change-Id: Id289ac3a9eb58627aef38d358ae8e683fc228981 Commit: 442d434faf352d5b7e07623b6fc4c32d2dfd446d https://github.com/tribe29/checkmk/commit/442d434faf352d5b7e07623b6fc4c32d2… Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com> Date: 2020-10-06 (Tue, 06 Oct 2020) Changed paths: M cmk/gui/wato/pages/pattern_editor.py M cmk/gui/watolib/rulesets.py M cmk/update_config.py M tests/testlib/pylint_checker_cmk_module_layers.py M tests/unit/test_pylint_checker_cmk_module_layers.py Log Message: ----------- pylint_checker_cmk_module_layers: fix allways true cases The _is_disallowed_{fetchers,snmplib}_import methods always returned `True`. Since cmk.utils is not (yet) listed as a component, it will be skipped, and `importing.startswith("cmk.utils"))` will always be false. Change-Id: I166ad791c0d154fc914ce56554ce493069d22632 Compare: https://github.com/tribe29/checkmk/compare/4a7a4b186dd3...442d434faf35