[checkmk-commits] [Checkmk/checkmk] 6ba6b6: Fix cse integration tests

Branch: refs/heads/2.3.0 Home: https://github.com/Checkmk/checkmk Commit: 6ba6b645779402795221a4ab44542d4f2d5e7e94 https://github.com/Checkmk/checkmk/commit/6ba6b645779402795221a4ab44542d4f2… Author: Max Linke <max.linke(a)checkmk.com> Date: 2024-07-04 (Thu, 04 Jul 2024) Changed paths: M tests/testlib/web_session.py Log Message: ----------- Fix cse integration tests The CSE is dynamically loading an onboarding script. The source for that script is hosted by checkmk outside of the site. We should not check for that resource during the tests Change-Id: Ife7688c722e7c8244f9c595ef625d3a22e905a19 Commit: 70996ee5835d3d2a38bdcbae19add11e4f36459d https://github.com/Checkmk/checkmk/commit/70996ee5835d3d2a38bdcbae19add11e4… Author: Lars Michelsen <lm(a)checkmk.com> Date: 2024-07-04 (Thu, 04 Jul 2024) Changed paths: M cmk/gui/sidebar/__init__.py M tests/unit/cmk/gui/test_pages.py Log Message: ----------- Clean up dependency on Saas specific code In general, the common Checmk code should not know anything about the Saas specific code. In some cases this needs some extra work, which we should always invest to keep a clean architecture. The edition specific conditions are a way to fulfil the requirements quickly, but result in a bad architecture which increase long term maintenance cost. This change move Saas specific code to cse package and inverses the dependency. The general Checkmk code now provides a hook which the Saas code can use to extend the common Checkmk code . This way the code is better encapsulated and the depdencies are clearer because we have less ad-hoc extensions. Change-Id: Ib1212ffb1c1c4f98bfbef3a8e222e8c0ba345f39 Compare: https://github.com/Checkmk/checkmk/compare/910f5391368d...70996ee5835d To unsubscribe from these emails, change your notification settings at https://github.com/Checkmk/checkmk/settings/notifications