[checkmk-commits] #2917 FIX cisco_asa_failover: Will no longer discover on devices where failover is disabled

Module: check_mk Branch: master Commit: d8f8354cb626d8b7532eed9ef20e8ed1beaf1649 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=d8f8354cb626d8… Author: Sebastian Herbord <sh(a)mathias-kettner.de> Date: Tue Jan 12 10:41:49 2016 +0100 #2917 FIX cisco_asa_failover: Will no longer discover on devices where failover is disabled If failover is disabled on a device, both primary and secondary units are reported as "down". check_mk reported a warning for that even though there was no problem. This change requires re-inventory of the affected devices. --- .werks/2917 | 11 +++++++++++ ChangeLog | 1 + checks/cisco_asa_failover | 5 +++++ 3 files changed, 17 insertions(+) diff --git a/.werks/2917 b/.werks/2917 new file mode 100644 index 0000000..2e3c75c --- /dev/null +++ b/.werks/2917 @@ -0,0 +1,11 @@ +Title: cisco_asa_failover: Will no longer discover on devices where failover is disabled +Level: 1 +Component: checks +Compatible: compat +Version: 1.2.7i4 +Date: 1452591537 +Class: fix + +If failover is disabled on a device, both primary and secondary units are reported as "down". +check_mk reported a warning for that even though there was no problem. +This change requires re-inventory of the affected devices. diff --git a/ChangeLog b/ChangeLog index 5fc634a..e2c3aca 100644 --- a/ChangeLog +++ b/ChangeLog @@ -178,6 +178,7 @@ * 2898 FIX: smart: Using normalized value for determining reallocated events state... * 2888 FIX: citrix_controller.licensing: ignoring double data from piggy backs * 2899 FIX: ps: Finally improved performance impact of perfdata when having a lot of processes... + * 2917 FIX: cisco_asa_failover: Will no longer discover on devices where failover is disabled... Multisite: * 2684 Added icons for downloading agent data / walks of hosts... diff --git a/checks/cisco_asa_failover b/checks/cisco_asa_failover index 361bac2..fb69e36 100644 --- a/checks/cisco_asa_failover +++ b/checks/cisco_asa_failover @@ -37,6 +37,11 @@ # [['Failover LAN Interface', '2', 'LAN_FO GigabitEthernet0/0.777'], ['Primary unit', '9', 'Active unit'], ['Secondary unit (this device)', '10', 'Standby unit']] def inventory_cisco_asa_failover(info): + for name, state, state_txt in info: + if name.lower() == "failover lan interface" and state == "3": + # clustering is disabled + return None + for deviceentry in info[-2:]: if "this device" in deviceentry[0]: return [ (None, None) ]