[checkmk-commits] [Checkmk/checkmk] 6a130a: Fix bazel dependencies for cmk.trace

Branch: refs/heads/master Home: https://github.com/Checkmk/checkmk Commit: 6a130a9cc2520a5257a0c030f8600c1864a598df https://github.com/Checkmk/checkmk/commit/6a130a9cc2520a5257a0c030f8600c186… Author: Lars Michelsen <lm(a)checkmk.com> Date: 2024-08-05 (Mon, 05 Aug 2024) Changed paths: M omd/packages/python3-modules/BUILD M omd/packages/python3-modules/build-python3-modules.bzl M packages/BUILD A packages/cmk-trace/BUILD Log Message: ----------- Fix bazel dependencies for cmk.trace So far it seems that the dynamically generated bazel target `trace_compile` (see omd/packages/python3-modules/BUILD) had a dependency on the `packages/cmk-trace` directory. It looks like the intention was to track all files below that directory, which is not how it works. This change tries to fix the broken dependencies by introducing a new file group to cover all files of a package. While this issue affects all `packages/cmk-*`, I won't touch it for now. This will be done by other colleagues separately Change-Id: Ibc0c81b60b9bca92510f6218f16852de3c2830ea Commit: 518b623b74a822ec58e2181aac4501eaf967e90e https://github.com/Checkmk/checkmk/commit/518b623b74a822ec58e2181aac4501eaf… Author: Lars Michelsen <lm(a)checkmk.com> Date: 2024-08-05 (Mon, 05 Aug 2024) Changed paths: M cmk/gui/background_job/_process.py M cmk/gui/log.py M cmk/gui/wsgi/applications/index.wsgi M packages/cmk-trace/cmk/trace/__init__.py A packages/cmk-trace/cmk/trace/_config.py A packages/cmk-trace/cmk/trace/export.py A packages/cmk-trace/cmk/trace/logs.py M packages/cmk-trace/tests/test_trace.py Log Message: ----------- Reland: Separate cmk.trace into modules It turned out that the dependencies that are pulled in by cmk.trace are too much for basic instrumenting use cases. The extreme is the OTLP exporter, which pulls in protobuf. This is not an acceptable dependency for code which just wants to create a span. Luckily the issue was caused by own code. So the solution is fairly straight forward: Separate `cmk.trace` into smaller parts which then can be pulled in individually by the call sites as needed. This is the first step which extracts the exporter setup and it's dependencies. Change-Id: I2ddea2bdb5569c3b91ad8a2bd4d474878212ad45 Commit: 44acccd0c29ce7019d32b1c87d6527acccafb4e4 https://github.com/Checkmk/checkmk/commit/44acccd0c29ce7019d32b1c87d6527acc… Author: Lars Michelsen <lm(a)checkmk.com> Date: 2024-08-05 (Mon, 05 Aug 2024) Changed paths: M cmk/gui/background_job/_base.py M cmk/gui/background_job/_interface.py M cmk/gui/wsgi/applications/index.wsgi M packages/cmk-trace/cmk/trace/__init__.py M packages/cmk-trace/cmk/trace/export.py M tests/unit/cmk/gui/test_background_job.py Log Message: ----------- Reland: Move span processor to cmk.trace.export It is closely related to the actual exporter, so it's better to keep it in the same module. Change-Id: Ifb908fcd3b21c24383b796e9eb177211103f2dda Compare: https://github.com/Checkmk/checkmk/compare/242cdf62e673...44acccd0c29c To unsubscribe from these emails, change your notification settings at https://github.com/Checkmk/checkmk/settings/notifications