[checkmk-commits] [tribe29/checkmk] a8f823: Pagetypes typing #1

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: a8f8230e6fd4680e0286cf166f755521d11d0257 https://github.com/tribe29/checkmk/commit/a8f8230e6fd4680e0286cf166f755521d… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2022-07-27 (Wed, 27 Jul 2022) Changed paths: M cmk/gui/pagetypes.py M cmk/gui/plugins/sidebar/bookmarks.py M cmk/gui/sidebar/__init__.py Log Message: ----------- Pagetypes typing #1 Type hint "internal representation" dict of pagetype classes Change-Id: I0c74114d585ac9027224c3c508c9522b52d53bd4 Commit: c713895b51c0041653b46cf4e10a74dc83ce068a https://github.com/tribe29/checkmk/commit/c713895b51c0041653b46cf4e10a74dc8… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2022-07-27 (Wed, 27 Jul 2022) Changed paths: M cmk/gui/pagetypes.py Log Message: ----------- Move Overridable specific members from Base to Overridable Change-Id: Ie5ca56445c341e3c6f9d33a6de9cd4476270e359 Commit: 75ec667f82de6679ef00c050bb3627c691d7c6a3 https://github.com/tribe29/checkmk/commit/75ec667f82de6679ef00c050bb3627c69… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2022-07-27 (Wed, 27 Jul 2022) Changed paths: M cmk/gui/pagetypes.py M cmk/gui/plugins/sidebar/bookmarks.py M cmk/gui/sidebar/__init__.py Log Message: ----------- Pagetypes typing #2 Add type hints to methods holding the instances of the overridables. These should clearly be managed in a container object instead of a class member variable. But that's something for a separate cleanup. Change-Id: Ied9ca60759b6f5af7ab7b5b2b3f2daac55bf2b12 Commit: 460a984e4eb4aeea3203b51ea46acc177de26b81 https://github.com/tribe29/checkmk/commit/460a984e4eb4aeea3203b51ea46acc177… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2022-07-27 (Wed, 27 Jul 2022) Changed paths: M cmk/gui/pagetypes.py M cmk/gui/plugins/sidebar/bookmarks.py M cmk/gui/plugins/sidebar/utils.py M cmk/gui/sidebar/__init__.py Log Message: ----------- Pagetypes typing #3 Spread type hints in all base and specific class methods. Especially in the graphing related page types we still miss a lot of type hints since there is much more than just the page type logic inside (e.g. the implementation of the graph editors) Change-Id: I2c6023edef23b6a5d18d7da0b3a16e49f6ecd307 Commit: f440e6d997e4d26bce7ed3f40e136d42a67dfdc5 https://github.com/tribe29/checkmk/commit/f440e6d997e4d26bce7ed3f40e136d42a… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2022-07-27 (Wed, 27 Jul 2022) Changed paths: M cmk/gui/pagetypes.py Log Message: ----------- pagetypes: Add abc And fix the uncovered bug. Change-Id: Ic79ece6c4d4c2913c5b9b9cbe7373367f7bb9d02 Commit: 82b226a9936a617977d6f248a032b9cc584ec693 https://github.com/tribe29/checkmk/commit/82b226a9936a617977d6f248a032b9cc5… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2022-07-27 (Wed, 27 Jul 2022) Changed paths: M cmk/gui/pagetypes.py M cmk/gui/sidebar/__init__.py Log Message: ----------- Pagetypes typing #4 Add some more type hints and remove one dead function Change-Id: Ibfd9e22b8eb83833ffa56be78c7fe054151b9ae1 Commit: 5cdd3a7bbf7997a78a06de5defc594542d72a5ef https://github.com/tribe29/checkmk/commit/5cdd3a7bbf7997a78a06de5defc594542… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2022-07-27 (Wed, 27 Jul 2022) Changed paths: M cmk/gui/pagetypes.py Log Message: ----------- Pagetypes typing #5 Add remaining type hints and enforce all functions to be typed on module level. Change-Id: I8c75e401af45b043bae17be514e3d4d4e9f8908f Compare: https://github.com/tribe29/checkmk/compare/9f4a439d95d7...5cdd3a7bbf79