[checkmk-commits] Classified a few more warnings.

Module: check_mk Branch: master Commit: cb0a47620732be055f1a00dc28144c6fd1c07d9f URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=cb0a47620732be… Author: Sven Panne <sp(a)mathias-kettner.de> Date: Mon Jul 23 14:58:24 2018 +0200 Classified a few more warnings. Change-Id: I4fea02635adb02ad0c5708088bf640226fe2c957 --- tests/pylint/pylintrc | 28 +++++++++++++++++++++------- 1 file changed, 21 insertions(+), 7 deletions(-) diff --git a/tests/pylint/pylintrc b/tests/pylint/pylintrc index 3b71e37..3fb6b4c 100644 --- a/tests/pylint/pylintrc +++ b/tests/pylint/pylintrc @@ -18,14 +18,8 @@ disable= consider-using-enumerate, consider-using-ternary, duplicate-code, - eval-used, - exec-used, - fixme, - global-statement, - global-variable-undefined, inconsistent-return-statements, len-as-condition, - line-too-long, logging-not-lazy, missing-docstring, multiple-imports, @@ -39,7 +33,6 @@ disable= reimported, relative-import, ungrouped-imports, - unidiomatic-typecheck, unsubscriptable-object, unsupported-membership-test, unused-argument, @@ -69,6 +62,15 @@ disable= # duplication (introduce new classes, combine methods, etc.) attribute-defined-outside-init, #--------------------------------------------------------------------------- + # Enabling this would be very desirable, using type() instead of + # isinstance() is a very bad idea most of the time, as it totally ignores + # class hierarchies, breaking things in subtle ways. + unidiomatic-typecheck, + #--------------------------------------------------------------------------- + # This should really be fixed: Global variables are already a bad idea, but + # depending on an implicit protocol to create them is an even worse one. + global-variable-undefined, + #--------------------------------------------------------------------------- # We should enable this, at the moment it just means splitting up two # gigantic functions. too-many-branches, @@ -87,6 +89,13 @@ disable= # a few violations, so we postpone fixing this. singleton-comparison, #--------------------------------------------------------------------------- + # Alas, these maintenance/security nightmares are still part of our base + # "technology"... :-/ Nevertheless, reducing their usage is a very worthy + # goal. + eval-used, + exec-used, + global-statement, + #--------------------------------------------------------------------------- # Enabling these would be nice, but given the current state of affairs # (gigantic modules with deeply nested humungous functions/methods), this # will be a non-trivial amount of work. @@ -101,10 +110,15 @@ disable= too-many-return-statements, too-many-statements, #--------------------------------------------------------------------------- + # Our code is still full of FIXMEs/XXXs/TODOs, perhaps fixing or removing + # them might be a good idea some day... + fixme, + #--------------------------------------------------------------------------- # The warnigns below will probably fixed by YAPF. bad-continuation, bad-indentation, bad-whitespace, + line-too-long, #--------------------------------------------------------------------------- # Enabling the two spelling-related checks increases pylints runtime from # 11 min to 40 min, so we better keep those disabled for normal runs.