[checkmk-commits] [tribe29/checkmk] 415586: Move Summarizer construction to Configurator

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 4155863a976dd3d212b1f8f4ae63dcc6b2e169b8 https://github.com/tribe29/checkmk/commit/4155863a976dd3d212b1f8f4ae63dcc6b… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2020-08-25 (Tue, 25 Aug 2020) Changed paths: M cmk/base/data_sources/_abstract.py M cmk/base/data_sources/agent.py M cmk/base/data_sources/ipmi.py M cmk/base/data_sources/piggyback.py M cmk/base/data_sources/programs.py M cmk/base/data_sources/snmp.py M cmk/base/data_sources/tcp.py M tests/unit/cmk/base/data_sources/test_agent.py M tests/unit/cmk/base/data_sources/test_ipmi_management_board_data_source.py M tests/unit/cmk/base/data_sources/test_piggy_back_data_source.py M tests/unit/cmk/base/data_sources/test_snmp_data_source.py M tests/unit/cmk/base/data_sources/test_tcp_data_source.py Log Message: ----------- Move Summarizer construction to Configurator The checking steps are: # fetch() -> RawData # check(RawData) -> HostSections # summarize(HostSections) -> ServiceCheckResult We have already moved the construction of the fetcher and of the checker to the configurator. It is but consistent to also move the summarizer there. In a next step, we might as well remove the summary out of the Checker/Parser to better separate the three steps and clarify the intent of the classes. In this patch, we further notice that we really only have two different Checker/Parsers: Agent and SNMP. We will simplify the Checker hierarchy in a coming patch as well. CMK-5275 Change-Id: Ib862d63f0f36bbf83e68dfa373112fac7bca4dbe Commit: ac306e6717279130e5cb2c45df00ea55ba8272e3 https://github.com/tribe29/checkmk/commit/ac306e6717279130e5cb2c45df00ea55b… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2020-08-25 (Tue, 25 Aug 2020) Changed paths: M cmk/base/data_sources/_abstract.py M cmk/base/data_sources/agent.py M cmk/base/data_sources/snmp.py Log Message: ----------- Move Parser construction to Configurator This is consistent with the construction of Fetcher, Checker, and Summarizer. This removes one more artificial difference between the classes deriving AgentChecker and moves us one step closer to removing that inheritance hierarchy. CMK-5275 Change-Id: Ie6b575b8324a2e388caa8e3e6ad196cf31db0149 Commit: 24b17d54c901444158769beb7d10c798be6b6a2a https://github.com/tribe29/checkmk/commit/24b17d54c901444158769beb7d10c798b… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2020-08-25 (Tue, 25 Aug 2020) Changed paths: M cmk/base/automations/check_mk.py M cmk/base/data_sources/tcp.py M cmk/base/modes/check_mk.py Log Message: ----------- Set TCPConfigurator.use_only_cache in TCPConfigurator CMK-5275 Change-Id: I73814983a5de9bd858fd98e09f0b136d16b0ef04 Commit: 4ab35b9dce8c05be8220cadd84c41395d1cefba0 https://github.com/tribe29/checkmk/commit/4ab35b9dce8c05be8220cadd84c41395d… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2020-08-25 (Tue, 25 Aug 2020) Changed paths: M cmk/base/data_sources/_abstract.py M cmk/base/data_sources/_data_sources.py M cmk/base/data_sources/agent.py M cmk/base/data_sources/snmp.py M tests/unit/cmk/base/data_sources/test_agent.py Log Message: ----------- Set the default_host_sections in the configurator We already have the default_raw_data there. In the end, it is possible that this all goes away. In the meantime, we just empty the AgentChecker classes. CMK-5275 Change-Id: I8ebeddf591b3766d3fc76ca0addef31cd9de211b Commit: 79e0c1ee5649ff00ebb04041d28c7e0a2deb5370 https://github.com/tribe29/checkmk/commit/79e0c1ee5649ff00ebb04041d28c7e0a2… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2020-08-25 (Tue, 25 Aug 2020) Changed paths: M cmk/base/data_sources/agent.py M cmk/base/data_sources/ipmi.py M cmk/base/data_sources/piggyback.py M cmk/base/data_sources/programs.py M cmk/base/data_sources/tcp.py M tests/unit/cmk/base/data_sources/test_host_sections.py M tests/unit/cmk/base/data_sources/test_ipmi_management_board_data_source.py M tests/unit/cmk/base/data_sources/test_piggy_back_data_source.py M tests/unit/cmk/base/data_sources/test_program_data_source.py M tests/unit/cmk/base/data_sources/test_snmp_data_source.py M tests/unit/cmk/base/data_sources/test_tcp_data_source.py Log Message: ----------- Remove AgentChecker hierarchy CMK-5275 Change-Id: Idace39964bc3c903af4a930835159d1252488e29 Compare: https://github.com/tribe29/checkmk/compare/63516cf871d5...79e0c1ee5649