[checkmk-commits] [tribe29/checkmk] b17937: 11814 FIX smart check: Evaluate command timeouts a...

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: b1793777092fcff4781a7ee977fd15c8f4b0fe01 https://github.com/tribe29/checkmk/commit/b1793777092fcff4781a7ee977fd15c8f… Author: Timotheus Bachinger <timotheus.bachinger(a)tribe29.com> Date: 2021-08-09 (Mon, 09 Aug 2021) Changed paths: A .werks/11814 M cmk/base/plugins/agent_based/smart.py M tests/unit/cmk/base/plugins/agent_based/test_smart.py Log Message: ----------- 11814 FIX smart check: Evaluate command timeouts as counter Previously, the metric "Command_Timeout" of the smart check was evaluated in the following manner: If the counter deviated from the discovered value, the check went {CRIT}. This led to a lot of false posivitves, as the counter may also increase after a simple reboot, which is no faulty situation. The rate however gives a better evaluation of the state. As from this werk, we allow all rates below 100 Command Timeouts per hour. SUP-7205 Change-Id: I06f98b19b023139869e0f960216f8cd7f79606f7 Commit: ae6fe5ef11d46fb8fd17af44487e1137e080a32e https://github.com/tribe29/checkmk/commit/ae6fe5ef11d46fb8fd17af44487e1137e… Author: Timotheus Bachinger <timotheus.bachinger(a)tribe29.com> Date: 2021-08-09 (Mon, 09 Aug 2021) Changed paths: M tests/unit/cmk/base/plugins/agent_based/test_smart.py Log Message: ----------- Cleanup string prefixes in test_smart.py Change-Id: I38359e0ca44cee0889fcbb279ab098a23a55bb4b Compare: https://github.com/tribe29/checkmk/compare/e197fa21427e...ae6fe5ef11d4