4 May
2021
4 May
'21
11:12 a.m.
Branch: refs/heads/master
Home: https://github.com/tribe29/checkmk
Commit: ea23d9143130b8d837237ce5490860a590407a37
https://github.com/tribe29/checkmk/commit/ea23d9143130b8d837237ce5490860a59…
Author: Lars Michelsen <lm(a)tribe29.com>
Date: 2021-05-04 (Tue, 04 May 2021)
Changed paths:
M cmk/gui/watolib/activate_changes.py
Log Message:
-----------
Cleanup activate changes site state path computation
Centralize computation of the temporary and persisted path.
Simplify call sites by removing useless instantiation of
ActivateChangesManager.
Change-Id: Iedb0a98794aaf79758049cd104063446521df195
Commit: 1f20a40cd6ed7011905b5a0d64299ae13db36d41
https://github.com/tribe29/checkmk/commit/1f20a40cd6ed7011905b5a0d64299ae13…
Author: Lars Michelsen <lm(a)tribe29.com>
Date: 2021-05-04 (Tue, 04 May 2021)
Changed paths:
M cmk/gui/watolib/activate_changes.py
Log Message:
-----------
Prepare to extract save_state
* Move all self references one level up to _set_result
* Move computation of state datastructure one level up
Change-Id: I263129dbabc1b14c257f8d6d629aba118a03f462
Commit: feeda8512bfe4d12d0eb3f110795303d003e0834
https://github.com/tribe29/checkmk/commit/feeda8512bfe4d12d0eb3f110795303d0…
Author: Lars Michelsen <lm(a)tribe29.com>
Date: 2021-05-04 (Tue, 04 May 2021)
Changed paths:
M cmk/gui/watolib/activate_changes.py
Log Message:
-----------
Add some type hints to assist during refactoring
Change-Id: I7688442de79e1ed8ebf7e8c01f85256605eaeee0
Commit: 8a215bed41f9c1ccb67bd65fd7da54c5e4a5c7d4
https://github.com/tribe29/checkmk/commit/8a215bed41f9c1ccb67bd65fd7da54c5e…
Author: Lars Michelsen <lm(a)tribe29.com>
Date: 2021-05-04 (Tue, 04 May 2021)
Changed paths:
M cmk/gui/watolib/activate_changes.py
M tests/unit/cmk/gui/watolib/test_activate_changes.py
Log Message:
-----------
Removed unused parameter
Change-Id: I19ef509e067e6bc3197e5c0dd6bd204efeb8f48d
Commit: db30b48554afc022cee2f753a2a6c80dea7d834b
https://github.com/tribe29/checkmk/commit/db30b48554afc022cee2f753a2a6c80de…
Author: Lars Michelsen <lm(a)tribe29.com>
Date: 2021-05-04 (Tue, 04 May 2021)
Changed paths:
M cmk/gui/watolib/activate_changes.py
M cmk/gui/watolib/sites.py
M tests/unit/cmk/gui/watolib/test_activate_changes.py
M tests/unit/cmk/gui/watolib/test_config_sync.py
Log Message:
-----------
Make site config directories activation specific
* The site directories are now below
<tt>var/check_mk/site_configs/[activation_id]/[site_id]</tt>.
* Extend housekeeping job ActivationCleanupBackgroundJob to also clean
up the site_configs directories.
* When removing sites from the configuration, the cleanup using
remove_site_config_directory() is not needed anymore.
Change-Id: I2a2e78f58a94a40e54cd159f3d8c967baf6987bf
Commit: 75b4e1f9154f5a43f88263ee3de9b69f91a1b887
https://github.com/tribe29/checkmk/commit/75b4e1f9154f5a43f88263ee3de9b69f9…
Author: Lars Michelsen <lm(a)tribe29.com>
Date: 2021-05-04 (Tue, 04 May 2021)
Changed paths:
A .werks/12828
Log Message:
-----------
12828 FIX Distributed setup: Fix parallel activations breaking remote sites
Previous 2.0.0 versions could break the Checkmk configuration on remote sites
when two users tried to activate changes for a single remote site at the same
time.
This was a race condition between both processes. While the first activation
performed the synchronization to the remote site, the second activation could
modify the files that are currently being synchronized by the first process.
This could lead to incomplete configurations on the remote site.
Since the first activation did not know anything about this inconsistency, it
tried to activate the incomplete configuration on the remote site after the
sychronization which could fail with different error messages depending on
which files were not transfered.
This issue only affected the configuration of remote sites. No configuration
was lost on the central site.
If you want to prevent this issue with previous 2.0.0 releases, you need to
ensure that you don't start two activations for a site at the same time.
Change-Id: Ifb319e9ee3507a1d7e396b0aac486af60b256b2e
Compare: https://github.com/tribe29/checkmk/compare/b065f6ab4a2a...75b4e1f9154f