10 Mar
2022
10 Mar
'22
12:52 p.m.
Branch: refs/heads/master
Home: https://github.com/tribe29/checkmk
Commit: 7901938bfd82a9b974895df8d98a3675f8b92305
https://github.com/tribe29/checkmk/commit/7901938bfd82a9b974895df8d98a3675f…
Author: Sven Panne <sven.panne(a)tribe29.com>
Date: 2022-03-10 (Thu, 10 Mar 2022)
Changed paths:
M .werks/13093
Log Message:
-----------
13093 Various ValueSpec-related API cleanups
Various changes have been done to <tt>ValueSpec</tt> and its subclasses,
improving maintainability and robustness. If you don't write your own
complicated <tt>ValueSpec</tt> subclasses and you don't have any
self-written
complicated check parameters, you are probably not affected.
<ul>
<li>
<tt>ValueSpec</tt>'s constructor doesn't accept any random
unspecifed
keyword arguments anymore. It is better to raise an exception at the
incorrect call site than silently accepting every typo. To fix any problems
with this change, just remove the offending keyword arguments, they served
no purpose after all.
</li>
<li>
<tt>ValueSpec.canonical_value()</tt> is an abstract method now, otherwise
we
force lots of places to handle <tt>None</tt>. Previously quite a few
things
worked only more or less by accident. If you implement your own
<tt>ValueSpec</tt> subclass, you have to implement that method now,
unless
an intermediate class already does it for you.
</li>
<li>
<tt>DropdownChoice</tt> and <tt>CascadingDropdown</tt>
don't have a
<tt>no_preselect</tt> keyword argument anymore. It was redundant, because
<tt>no_preselect_title</tt> is enough: If this keyword argument is not
<tt>None</tt>, <tt>no_preselect=True</tt> is implied.
Previously one could
specify nonsensical combinations of those arguments. To fix any problems
with this change, just drop the <tt>no_preselect</tt> keyword argument.
</li>
<li>
<tt>Alternative</tt>, <tt>UploadOrPasteTextFile</tt>,
<tt>TextOrRegExp</tt>,
and <tt>CAorCAChain</tt> don't have a <tt>style</tt>
keyword argument
anymore. It didn't serve any purpose since Checkmk 2.0. Just remove it.
</li>
</ul>
Change-Id: Ie1b183f941a45a913bc741541aaae123231f9808
Commit: 6ac0f5049bb61b996562222476a98adcbe170b6b
https://github.com/tribe29/checkmk/commit/6ac0f5049bb61b996562222476a98adcb…
Author: Sven Panne <sven.panne(a)tribe29.com>
Date: 2022-03-10 (Thu, 10 Mar 2022)
Changed paths:
M .werks/13093
Log Message:
-----------
Revert "13093 Various ValueSpec-related API cleanups"
Somehow the werks numbers clashed... :-/
This reverts commit 7901938bfd82a9b974895df8d98a3675f8b92305.
Commit: 0b29e49748da3f4902dc907b57b7139f63a10762
https://github.com/tribe29/checkmk/commit/0b29e49748da3f4902dc907b57b7139f6…
Author: Sven Panne <sven.panne(a)tribe29.com>
Date: 2022-03-10 (Thu, 10 Mar 2022)
Changed paths:
A .werks/13094
Log Message:
-----------
13094 Various ValueSpec-related API cleanups
Various changes have been done to <tt>ValueSpec</tt> and its subclasses,
improving maintainability and robustness. If you don't write your own
complicated <tt>ValueSpec</tt> subclasses and you don't have any
self-written
complicated check parameters, you are probably not affected.
<ul>
<li>
<tt>ValueSpec</tt>'s constructor doesn't accept any random
unspecifed
keyword arguments anymore. It is better to raise an exception at the
incorrect call site than silently accepting every typo. To fix any problems
with this change, just remove the offending keyword arguments, they served
no purpose after all.
</li>
<li>
<tt>ValueSpec.canonical_value()</tt> is an abstract method now, otherwise
we
force lots of places to handle <tt>None</tt>. Previously quite a few
things
worked only more or less by accident. If you implement your own
<tt>ValueSpec</tt> subclass, you have to implement that method now,
unless
an intermediate class already does it for you.
</li>
<li>
<tt>DropdownChoice</tt> and <tt>CascadingDropdown</tt>
don't have a
<tt>no_preselect</tt> keyword argument anymore. It was redundant, because
<tt>no_preselect_title</tt> is enough: If this keyword argument is not
<tt>None</tt>, <tt>no_preselect=True</tt> is implied.
Previously one could
specify nonsensical combinations of those arguments. To fix any problems
with this change, just drop the <tt>no_preselect</tt> keyword argument.
</li>
<li>
<tt>Alternative</tt>, <tt>UploadOrPasteTextFile</tt>,
<tt>TextOrRegExp</tt>,
and <tt>CAorCAChain</tt> don't have a <tt>style</tt>
keyword argument
anymore. It didn't serve any purpose since Checkmk 2.0. Just remove it.
</li>
</ul>
Change-Id: I7cb1aad259b3a0c79594b6bf22e08acea7ed8220
Compare: https://github.com/tribe29/checkmk/compare/2061a88817a7...0b29e49748da