30 May
2023
30 May
'23
8:13 a.m.
Branch: refs/heads/master
Home: https://github.com/Checkmk/checkmk
Commit: f25b3260642f87f31e68f8a82fc4ac9c36d6e1f4
https://github.com/Checkmk/checkmk/commit/f25b3260642f87f31e68f8a82fc4ac9c3…
Author: Lars Michelsen <lm(a)checkmk.com>
Date: 2023-05-30 (Tue, 30 May 2023)
Changed paths:
M cmk/gui/autocompleters.py
M cmk/gui/fields/definitions.py
M cmk/gui/plugins/openapi/endpoints/folder_config.py
M cmk/gui/plugins/openapi/endpoints/host_config.py
M cmk/gui/plugins/sidebar/virtual_host_tree.py
M cmk/gui/plugins/sidebar/wato.py
M cmk/gui/plugins/visuals/wato.py
M cmk/gui/plugins/wato/bi_valuespecs.py
M cmk/gui/plugins/wato/utils/__init__.py
M cmk/gui/wato/pages/activate_changes.py
M cmk/gui/wato/pages/folders.py
M cmk/gui/wato/pages/parentscan.py
M cmk/gui/wato/pages/predefined_conditions.py
M cmk/gui/wato/pages/rulesets.py
M cmk/gui/wato/pages/services.py
M cmk/gui/wato/pages/sites.py
M cmk/gui/wato/pages/tags.py
M cmk/gui/watolib/_host_attributes.py
M cmk/gui/watolib/automatic_host_removal.py
M cmk/gui/watolib/bulk_discovery.py
M cmk/gui/watolib/custom_attributes.py
M cmk/gui/watolib/groups.py
M cmk/gui/watolib/host_rename.py
M cmk/gui/watolib/hosts_and_folders.py
M cmk/gui/watolib/network_scan.py
M cmk/gui/watolib/rulesets.py
M cmk/gui/watolib/sample_config.py
M cmk/gui/watolib/sites.py
M cmk/gui/watolib/tags.py
M cmk/post_rename_site/plugins/actions/hosts_and_folders.py
M cmk/update_config/plugins/actions/unused_host_attributes.py
M tests/unit/cmk/gui/conftest.py
M tests/unit/cmk/gui/plugins/openapi/test_openapi_host_config.py
M tests/unit/cmk/gui/watolib/test_automatic_host_removal.py
M tests/unit/cmk/gui/watolib/test_gui_rulesets.py
M tests/unit/cmk/gui/watolib/test_hosts_and_folders.py
M tests/unit/cmk/gui/watolib/test_services.py
M tests/unit/cmk/gui/watolib/test_watolib_search.py
M tests/unit/cmk/post_rename_site/plugins/actions/test_hosts_and_folders_action.py
Log Message:
-----------
Extract collection related staticmethod from Folder
The folders, used to organize hosts, are represented in a tree. So far
the logic for interfacing with the tree was implemented as staticmethods
on the Folder class. Together with all the other code in the Folder
class this created a hard to understand mess.
This change now extracts these functions in order to separate the code
for managing a tree of folders.
It's still far from ideal. The state was previously held in a request
global which we also need to do now to not end up with a huge change. In
subsequent steps it might make sense to propagate the FolderTree object
through the application. However, the goal for now is to simplify the
Folder class by extracting functionality from it.
Change-Id: Ie6651aaede27f02e87532a41680320c1ec5f4ac0
Commit: 059bb96562da52a31ee67d32c462eafc6e02bea3
https://github.com/Checkmk/checkmk/commit/059bb96562da52a31ee67d32c462eafc6…
Author: Lars Michelsen <lm(a)checkmk.com>
Date: 2023-05-30 (Tue, 30 May 2023)
Changed paths:
M cmk/gui/plugins/wato/utils/__init__.py
M cmk/gui/plugins/wato/utils/context_buttons.py
M cmk/gui/wato/pages/bulk_discovery.py
M cmk/gui/wato/pages/bulk_edit.py
M cmk/gui/wato/pages/bulk_import.py
M cmk/gui/wato/pages/fetch_agent_output.py
M cmk/gui/wato/pages/folders.py
M cmk/gui/wato/pages/host_diagnose.py
M cmk/gui/wato/pages/host_rename.py
M cmk/gui/wato/pages/hosts.py
M cmk/gui/wato/pages/object_parameters.py
M cmk/gui/wato/pages/parentscan.py
M cmk/gui/wato/pages/pattern_editor.py
M cmk/gui/wato/pages/random_hosts.py
M cmk/gui/wato/pages/rulesets.py
M cmk/gui/wato/pages/search.py
M cmk/gui/wato/pages/services.py
M cmk/gui/watolib/bulk_discovery.py
M cmk/gui/watolib/hosts_and_folders.py
M cmk/gui/watolib/rulesets.py
Log Message:
-----------
Extract current request related staticmethod from Folder
The typing of folder_from_request is currently broken, because it can
return other types than reported. This will be fixed in a follow up
change.
Change-Id: I87e06e466572e5513b55ae7da79434c0efbcb51d
Compare: https://github.com/Checkmk/checkmk/compare/ca558b0aee57...059bb96562da