[checkmk-commits] [tribe29/checkmk] 694537: Revert "Drop inline-SNMP statistics"

Branch: refs/heads/test_weblate2 Home: https://github.com/tribe29/checkmk Commit: 69453742a96087d7f149a71bd84cf27a77a79355 https://github.com/tribe29/checkmk/commit/69453742a96087d7f149a71bd84cf27a7… Author: Mathias Laurin &lt;mathias.laurin(a)tribe29.com&gt; Date: 2020-10-27 (Tue, 27 Oct 2020) Changed paths: M cmk/base/automations/check_mk.py M cmk/base/checking.py M cmk/base/config.py M cmk/base/default_config/base.py M cmk/gui/plugins/wato/check_mk_configuration.py M cmk/snmplib/type_defs.py M tests/integration/cmk/lib/snmplib/backend_snmp.py M tests/integration/cmk/lib/snmplib/conftest.py M tests/unit/cmk/fetchers/test_classic_snmp.py M tests/unit/cmk/fetchers/test_fetchers.py M tests/unit/cmk/gui/watolib/test_watolib.py M tests/unit/cmk/lib/test_snmplib_snmp_scan.py M tests/unit/cmk/lib/test_snmplib_snmp_table.py Log Message: ----------- Revert "Drop inline-SNMP statistics" May need more work in WATO. This reverts commit a9a548217e1cfd79fb5d2256258b5ac51df8c931. Change-Id: Ibf4141f8a92167cce6e3796c933387dd99097e57 Commit: 7638871b81276dd0904eafec8cb6cd0491d1a09f https://github.com/tribe29/checkmk/commit/7638871b81276dd0904eafec8cb6cd049… Author: Lisa Pichler &lt;lisa.pichler(a)tribe29.com&gt; Date: 2020-10-27 (Tue, 27 Oct 2020) Changed paths: A .werks/11332 M cmk/special_agents/agent_aws.py M tests/unit/cmk/special_agents/agent_aws/test_agent_aws_s3.py Log Message: ----------- 11332 FIX agent_aws: set granularity of reported data correctly The AWS agent sets the Period API parameter (granularity of the data returned, e.g. daily) based on its caching interval. These two used to be the same. However, with the implementation of a dynamic caching interval (i.e. based on seconds since midnight rather than a hard-coded value), this holds no longer true. The granularity is now defined as a seperate property. CMK-5838 Change-Id: I11a96cc3f9048a6536c09ebfeb7197cd0dcab90a Commit: eb47ceb92dab4c5bc0657a59e99b8631f0598816 https://github.com/tribe29/checkmk/commit/eb47ceb92dab4c5bc0657a59e99b8631f… Author: Mathias Laurin &lt;mathias.laurin(a)tribe29.com&gt; Date: 2020-10-27 (Tue, 27 Oct 2020) Changed paths: M cmk/base/automations/check_mk.py M cmk/base/checking.py M cmk/base/config.py M cmk/base/default_config/base.py M cmk/gui/plugins/wato/check_mk_configuration.py M cmk/snmplib/type_defs.py M tests/integration/cmk/lib/snmplib/backend_snmp.py M tests/integration/cmk/lib/snmplib/conftest.py M tests/unit/cmk/fetchers/test_classic_snmp.py M tests/unit/cmk/fetchers/test_fetchers.py M tests/unit/cmk/gui/watolib/test_watolib.py M tests/unit/cmk/lib/test_snmplib_snmp_scan.py M tests/unit/cmk/lib/test_snmplib_snmp_table.py Log Message: ----------- Revert^2 "Drop inline-SNMP statistics" Probably not the culprit. This reverts commit 69453742a96087d7f149a71bd84cf27a77a79355. Change-Id: Id43c5edc9910972295a17cc4e3b0e8598000c579 Commit: 82281c80b5beafb63f060e7529d44cc24f4e6d8c https://github.com/tribe29/checkmk/commit/82281c80b5beafb63f060e7529d44cc24… Author: Joerg Herbel &lt;joerg.herbel(a)tribe29.com&gt; Date: 2020-10-27 (Tue, 27 Oct 2020) Changed paths: M cmk/gui/watolib/search.py Log Message: ----------- Setup search: add ident to searchable attributes for global settings This make the setup search find global settings also via their ident. CMK-6068 Change-Id: I8170669f53ceef65b7cf4db28284acba6e1bcd97 Commit: 3ff18d4db425adc450537df0cb7797a9e8d0b624 https://github.com/tribe29/checkmk/commit/3ff18d4db425adc450537df0cb7797a9e… Author: Lisa Pichler &lt;lisa.pichler(a)tribe29.com&gt; Date: 2020-10-27 (Tue, 27 Oct 2020) Changed paths: M cmk/special_agents/agent_aws.py Log Message: ----------- agent_aws: simplify period validation The parameter "Period" is the granularity of the data returned by the AWS API. This parameter has a few constraints: in most cases it should be a multiple of 60 (see https://docs.aws.amazon.com/AmazonCloudWatch/latest/APIReference/API_Metric…). The granularity was previously set using each endpoint's caching interval. It is a different property though, and is now set independently. It is therefore not necessary to ensure that the caching interval meets the constraints of the "Period" parameter. CMK-5838 Change-Id: I2ae4551491a656e6f12541e09b2fadb7137ccf33 Commit: 03f4520bf7115cff8e94e7299d41041900bab379 https://github.com/tribe29/checkmk/commit/03f4520bf7115cff8e94e7299d4104190… Author: Moritz Kiemer &lt;moritz.kiemer(a)tribe29.com&gt; Date: 2020-10-27 (Tue, 27 Oct 2020) Changed paths: M cmk/base/plugins/agent_based/smart.py M tests/unit/cmk/base/plugins/agent_based/test_smart.py Log Message: ----------- smart: shorten serivce output Change-Id: I7353a3476cda84a41ab951bb1619957d01a78a6b Commit: 54831368edc61511354a7109a787298eb8cd5c2b https://github.com/tribe29/checkmk/commit/54831368edc61511354a7109a787298eb… Author: Baptiste Pichot &lt;pichot(a)ill.fr&gt; Date: 2020-10-27 (Tue, 27 Oct 2020) Changed paths: A .werks/11407 M checks/zpool Log Message: ----------- 11407 FIX Added support for petabytes in zpool check This merges PR #228, https://github.com/tribe29/checkmk/pull/228. Jira: CMK-5211 Change-Id: Idf0dc0a38e39a24494064c09004ca015566e17c5 Commit: e9fcf2db6cbf0dc28ef3576df8fec1098f4f355b https://github.com/tribe29/checkmk/commit/e9fcf2db6cbf0dc28ef3576df8fec1098… Author: Andreas Umbreit &lt;andreas.umbreit(a)tribe29.com&gt; Date: 2020-10-27 (Tue, 27 Oct 2020) Changed paths: M tests/integration/cmk/utils/test_msi_engine_it.py Log Message: ----------- Augment test case for generate_product_version generate_product_version has recently been fixed (did not translate "2.0.0i1" properly). This is the missing test case. Change-Id: I968a8056e03b3ff6fde2842c73dab0009de22b56 Commit: af4841f0ccf5d6c0956d0c9cbfaa1982a0941266 https://github.com/tribe29/checkmk/commit/af4841f0ccf5d6c0956d0c9cbfaa1982a… Author: Andreas Umbreit &lt;andreas.umbreit(a)tribe29.com&gt; Date: 2020-10-27 (Tue, 27 Oct 2020) Changed paths: A .werks/11406 Log Message: ----------- 11406 FIX Improved product version for Windows agent package Windows product versions are an expression of 4 numbers, with the scheme <tt>major.minor.build.revision</tt>. Up to now, baked Windows agent MSI packages only make use of the <tt>major.minor.build</tt> part, writing a default value of <tt>12345</tt> to the revision part. The agent bakery now also makes use of the revision part, using an encoded representation of the innovation/beta/patch part of the Checkmk version, that preserves the order of the Checkmk versioning scheme. It's best explained by an example: <ul> <li>Checkmk version: <code>2.0.0i1</code> <ul> <li>Old product version: <tt>2.0.0.12345</tt></li> <li>New product version: <tt>2.0.0.10100</tt></li> </ul> </li> <li>Checkmk version: <tt>2.0.0p5</tt> <ul> <li>Old product version: <tt>2.0.0.12345</tt></li> <li>New product version: <tt>2.0.0.50005</tt></li> </ul> </li> </ul> CMK-5928 Change-Id: Ia9fa34b035ae6a1ae49c734e2ebf531488eb5fb9 Commit: 54025128ab4f4584ec5826c2cd09246fbbc019be https://github.com/tribe29/checkmk/commit/54025128ab4f4584ec5826c2cd09246fb… Author: Moritz Kiemer &lt;moritz.kiemer(a)tribe29.com&gt; Date: 2020-10-27 (Tue, 27 Oct 2020) Changed paths: M tests/unit/cmk/base/test_checks.py Log Message: ----------- unit tests: remove test against from imports Checks these days have their own contexts, so from imports are not as bad as they used to be. In addition, from imports are quite handy when migrating code to the new API one function at a time, so we allow them. Change-Id: Ic52b3be060070d344a9f966f963f0dc3b12930b2 Commit: 5d0d954daafc79442a3727861c0133caaccfcdb6 https://github.com/tribe29/checkmk/commit/5d0d954daafc79442a3727861c0133caa… Author: Moritz Kiemer &lt;moritz.kiemer(a)tribe29.com&gt; Date: 2020-10-27 (Tue, 27 Oct 2020) Changed paths: M inventory/dmidecode Log Message: ----------- dmidecode: add typing and refactor Note that all the "parse" functions are no parse functions in our usual sense. * add type annotations * refacor main function `inv_dmidecode` to prepare to factor out "parse function" * refactor `inv_dmidecode_parse_general` into `_make_dict`, which will be useful when migrating to new API. This change is probably best read from bottom to top. Change-Id: Id2ce33f9bbb590dd0e5602286ffddc4a12aee6f3 Commit: 32beec22bc240207035c0c0c242f0c2df1880682 https://github.com/tribe29/checkmk/commit/32beec22bc240207035c0c0c242f0c2df… Author: Lukas Lengler &lt;lukas.lengler(a)tribe29.com&gt; Date: 2020-10-27 (Tue, 27 Oct 2020) Changed paths: M cmk/base/checkers/fetcher_configuration.py M cmk/base/checkers/snmp.py M cmk/base/checking.py M cmk/base/config.py M cmk/base/crash_reporting.py M cmk/base/default_config/base.py M cmk/fetchers/factory.py M cmk/gui/plugins/wato/check_mk_configuration.py M cmk/snmplib/type_defs.py M cmk/update_config.py M cmk/utils/python_printer.py M tests/integration/cmk/lib/snmplib/backend_snmp.py M tests/integration/cmk/lib/snmplib/conftest.py M tests/integration/cmk/lib/snmplib/test_snmp_table.py M tests/unit/cmk/fetchers/test_classic_snmp.py M tests/unit/cmk/fetchers/test_fetchers.py M tests/unit/cmk/lib/test_snmplib_snmp_scan.py M tests/unit/cmk/lib/test_snmplib_snmp_table.py Log Message: ----------- Replaced typing of SNMPBackend Replaced string typing with Enum typing Change-Id: Ic101cc8fe43b957665b1dcf0535df51fc146142c Commit: d12eca49787222fd111b002d6720b1ae1febd38d https://github.com/tribe29/checkmk/commit/d12eca49787222fd111b002d6720b1ae1… Author: Lisa Pichler &lt;lisa.pichler(a)tribe29.com&gt; Date: 2020-10-27 (Tue, 27 Oct 2020) Changed paths: A tests/unit/cmk/gui/plugins/views/perfometers/test_perfometer_fileinfo.py Log Message: ----------- fileinfo.groups: added test for GUI perfometer transformation CMK-6051 Change-Id: I97b0846a6a70e2a8b3b9a375c5f90a117ea94874 Commit: f0af5ae5488612a622098cdd78fcc5c8b02b17d5 https://github.com/tribe29/checkmk/commit/f0af5ae5488612a622098cdd78fcc5c8b… Author: Wontek Hong &lt;wontek.hong(a)tribe29.com&gt; Date: 2020-10-27 (Tue, 27 Oct 2020) Changed paths: M cmk/gui/plugins/openapi/endpoints/host_tag.py Log Message: ----------- API: mypy fix for host_tag Change-Id: Ic1ba577533d6be840b29c1836176ee8776c13fc7 Commit: 73137722ad015d9d0e826d2603241cd15676caa6 https://github.com/tribe29/checkmk/commit/73137722ad015d9d0e826d2603241cd15… Author: Lisa Pichler &lt;lisa.pichler(a)tribe29.com&gt; Date: 2020-10-27 (Tue, 27 Oct 2020) Changed paths: A .werks/11334 M checks/fileinfo M tests/unit/checks/test_fileinfo_check.py Log Message: ----------- 11334 FIX fileinfo.groups: fixed crash when no files are found CMK-6051 Change-Id: I36bceba35ed6d70e22907099dd15a806906b48c0 Commit: d06b5f8afa192b1dc8ee9821a412542cd0a930a5 https://github.com/tribe29/checkmk/commit/d06b5f8afa192b1dc8ee9821a412542cd… Author: Lisa Pichler &lt;lisa.pichler(a)tribe29.com&gt; Date: 2020-10-27 (Tue, 27 Oct 2020) Changed paths: M tests/unit/checks/test_fileinfo_check.py Log Message: ----------- fileinfo.groups: added test for grouping patterns CMK-6051 Change-Id: I20f9918a1de77c74d2886faca809277791605052 Commit: 6291bb4759d6847700a3b62885d4c10dd47cf9ab https://github.com/tribe29/checkmk/commit/6291bb4759d6847700a3b62885d4c10dd… Author: a-s-995 &lt;antoinescheffold(a)gmail.com&gt; Date: 2020-10-27 (Tue, 27 Oct 2020) Changed paths: A .werks/11369 M checkman/windows_tasks M checks/windows_tasks A cmk/gui/plugins/wato/check_parameters/windows_tasks.py M tests/unit/checks/generictests/datasets/windows_tasks.py Log Message: ----------- 11369 windows_tasks: Make check configurable & improve output This werk enhances the check plugin <tt>windows_tasks</tt>. This plugin can now handle all of the exit codes of Windows tasks specified under https://docs.microsoft.com/en-us/windows/win32/taskschd/task-scheduler-erro…. Previously, the check plugin could only handle some of these exit codes and went CRIT if it encountered an unknown exit code. Furthermore, the check plugin now discovers any task which is not disabled. Previously, only tasks in the state "Enabled" were discovered. Moreover, the check plugin is now user-configurable via the new ruleset "Windows Tasks". Here, users can modify the default mapping of exit codes to monitoring states used by the check and users can also change the text produced by the check plugin for a given exit code. Finally, users can also change the monitoring state for tasks which are not enabled (the default monitoring state in such cases used to be CRIT, it is now WARN). This merges PR #186, https://github.com/tribe29/checkmk/pull/186. CMK-4553 Change-Id: I37bcb9fdf778ea8a09c87159760561119ba862fd Commit: a671c947973538b3b2333b618c54828a0ae4769d https://github.com/tribe29/checkmk/commit/a671c947973538b3b2333b618c54828a0… Author: Joerg Herbel &lt;joerg.herbel(a)tribe29.com&gt; Date: 2020-10-27 (Tue, 27 Oct 2020) Changed paths: M cmk/gui/watolib/hosts_and_folders.py Log Message: ----------- Setup search: make alias and ip addresses of hosts searchable CMK-6068 Change-Id: I36be5ab0e3cc88bad2d8265839759e1868c1c56a Commit: 1d4f2bee489551d1e21460da17f20745b48e09c3 https://github.com/tribe29/checkmk/commit/1d4f2bee489551d1e21460da17f20745b… Author: Lisa Pichler &lt;lisa.pichler(a)tribe29.com&gt; Date: 2020-10-27 (Tue, 27 Oct 2020) Changed paths: A .werks/11533 M cmk/gui/plugins/views/perfometers/check_mk.py M tests/unit/cmk/gui/plugins/views/perfometers/test_perfometer_fileinfo.py Log Message: ----------- 11533 FIX fileinfo.groups: fix broken perfometer when no files are found CMK-6051 Change-Id: Iab0b952352ed3afcedd42cfefa2790cb0e9e651d Commit: dbb2c34b0831e76c111c3947acbcf9ccb5049bdf https://github.com/tribe29/checkmk/commit/dbb2c34b0831e76c111c3947acbcf9ccb… Author: Mathias Laurin &lt;mathias.laurin(a)tribe29.com&gt; Date: 2020-10-27 (Tue, 27 Oct 2020) Changed paths: M cmk/base/checkers/_checkers.py M cmk/base/checking.py M cmk/base/discovery.py M cmk/base/inventory.py M tests/unit/cmk/base/checkers/test_host_sections.py Log Message: ----------- Fix update_host_sections type `Optional[Sequence]` is a code smell and introduces an actual bug in `update_host_sections`, where `fetcher_messages: Optional[Sequence] = None` triggers an unwanted call to `Fetcher.fetch()`. We therefore change the type of from `Optional[Sequence]` to `Sequence` and track and fix the call sites. CMK-5815 Change-Id: I871afb325680b59af60604a3cb99191d940d6bb7 Commit: 9d4984a35c9e95f411ae73f552bd4b989bf1419b https://github.com/tribe29/checkmk/commit/9d4984a35c9e95f411ae73f552bd4b989… Author: Mathias Laurin &lt;mathias.laurin(a)tribe29.com&gt; Date: 2020-10-27 (Tue, 27 Oct 2020) Changed paths: M cmk/base/checking.py M cmk/base/discovery.py M cmk/base/modes/check_mk.py Log Message: ----------- Improve consistency btw `do_check` and `check_discovery` Both functions may be used interchangeably in parts of our code, such as in the DiscoCheckExecutor so that the added consistency helps to avoid bugs. Moreover, the last two arguments to `do_check()` are optional sequences so that swapping them may remain undetected by the type checker. Making them keyword only fixes this issue. CMK-5815 Change-Id: I65507f39d42d0aab30c1bfff32c65cffbc465705 Commit: 3a4e1d768c81a75887c02dc7706400c841140516 https://github.com/tribe29/checkmk/commit/3a4e1d768c81a75887c02dc7706400c84… Author: Óscar Nájera &lt;oscar.najera(a)tribe29.com&gt; Date: 2020-10-27 (Tue, 27 Oct 2020) Changed paths: M cmk/gui/plugins/dashboard/graph.py Log Message: ----------- Fix graph dashlets init When adding a new graph dashlet, templated or custom, it is not yet possible to infer the graph identification, thus skip that initialization step until the dashlet is configured. CMK-6080 Change-Id: I924943e95aaecc5633bfbd72966dcb942c34c3a2 Commit: ac1e4d6ab39bfc6b114c5fa2ad422710501e8a63 https://github.com/tribe29/checkmk/commit/ac1e4d6ab39bfc6b114c5fa2ad4227105… Author: Lisa Pichler &lt;lisa.pichler(a)tribe29.com&gt; Date: 2020-10-27 (Tue, 27 Oct 2020) Changed paths: A .werks/11530 M checks/fileinfo M tests/unit/checks/test_fileinfo_check.py Log Message: ----------- 11530 FIX fileinfo.groups: fixed grouping pattern error when no files are found CMK-6051 Change-Id: I6e80611b2a20069a05f1c352275f874f44213ae5 Commit: 2a4af7686950f242b5b37039b21fdd628cc6ac68 https://github.com/tribe29/checkmk/commit/2a4af7686950f242b5b37039b21fdd628… Author: Lars Michelsen &lt;lm(a)tribe29.com&gt; Date: 2020-10-27 (Tue, 27 Oct 2020) Changed paths: M cmk/gui/plugins/views/availability.py M cmk/gui/plugins/views/painters.py M cmk/notification_plugins/mail.py M tests/unit/cmk/gui/test_views.py M tests/unit/cmk/notifications/test_mail.py Log Message: ----------- Establish the new terms for plugin outputs Plugin output -> summary Long output -> details Change-Id: I12330e3f3bfdd870afe37ce74fc29d58bc974866 Commit: 07586beef92db8fc92eda0255fb20d75606b6aaf https://github.com/tribe29/checkmk/commit/07586beef92db8fc92eda0255fb20d756… Author: Lars Michelsen &lt;lm(a)tribe29.com&gt; Date: 2020-10-27 (Tue, 27 Oct 2020) Changed paths: M cmk/gui/plugins/views/painters.py M cmk/gui/plugins/views/utils.py M cmk/gui/views.py Log Message: ----------- Introduce list_title for painters lists of painters (e.g. in the view editor). We now can use the list_title method of painters to customize it. Set the list title for the summary and details painters. Change-Id: I35342bf0e280e813677f747a2cb940e17e2fa6a0 Commit: 7045d8f2a9431a9cf49674f8f3b6ee384b198973 https://github.com/tribe29/checkmk/commit/7045d8f2a9431a9cf49674f8f3b6ee384… Author: Joerg Herbel &lt;joerg.herbel(a)tribe29.com&gt; Date: 2020-10-27 (Tue, 27 Oct 2020) Changed paths: A .werks/11332 A .werks/11334 A .werks/11369 A .werks/11406 A .werks/11407 A .werks/11530 A .werks/11533 M checkman/windows_tasks M checks/fileinfo M checks/windows_tasks M checks/zpool M cmk/base/checkers/_checkers.py M cmk/base/checkers/fetcher_configuration.py M cmk/base/checkers/snmp.py M cmk/base/checking.py M cmk/base/config.py M cmk/base/crash_reporting.py M cmk/base/default_config/base.py M cmk/base/discovery.py M cmk/base/inventory.py M cmk/base/modes/check_mk.py M cmk/base/plugins/agent_based/smart.py M cmk/fetchers/factory.py M cmk/gui/plugins/dashboard/graph.py M cmk/gui/plugins/openapi/endpoints/host_tag.py M cmk/gui/plugins/views/availability.py M cmk/gui/plugins/views/painters.py M cmk/gui/plugins/views/perfometers/check_mk.py M cmk/gui/plugins/views/utils.py M cmk/gui/plugins/wato/check_mk_configuration.py A cmk/gui/plugins/wato/check_parameters/windows_tasks.py M cmk/gui/views.py M cmk/gui/watolib/hosts_and_folders.py M cmk/gui/watolib/search.py M cmk/notification_plugins/mail.py M cmk/snmplib/type_defs.py M cmk/special_agents/agent_aws.py M cmk/update_config.py M cmk/utils/python_printer.py M inventory/dmidecode M tests/integration/cmk/lib/snmplib/backend_snmp.py M tests/integration/cmk/lib/snmplib/conftest.py M tests/integration/cmk/lib/snmplib/test_snmp_table.py M tests/integration/cmk/utils/test_msi_engine_it.py M tests/unit/checks/generictests/datasets/windows_tasks.py M tests/unit/checks/test_fileinfo_check.py M tests/unit/cmk/base/checkers/test_host_sections.py M tests/unit/cmk/base/plugins/agent_based/test_smart.py M tests/unit/cmk/base/test_checks.py M tests/unit/cmk/fetchers/test_classic_snmp.py M tests/unit/cmk/fetchers/test_fetchers.py A tests/unit/cmk/gui/plugins/views/perfometers/test_perfometer_fileinfo.py M tests/unit/cmk/gui/test_views.py M tests/unit/cmk/lib/test_snmplib_snmp_scan.py M tests/unit/cmk/lib/test_snmplib_snmp_table.py M tests/unit/cmk/notifications/test_mail.py M tests/unit/cmk/special_agents/agent_aws/test_agent_aws_s3.py Log Message: ----------- Merge branch 'master' into test_weblate2 Change-Id: I254dfa874e66114bd7e42d01987161606780e0b3 Compare: https://github.com/tribe29/checkmk/compare/191406dfccb8...7045d8f2a943