[checkmk-commits] [tribe29/checkmk] 238735: Add basic unit test for core config creation

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 238735d913015e6fde62d3c3d62e9cc83c6fa4c7 https://github.com/tribe29/checkmk/commit/238735d913015e6fde62d3c3d62e9cc83… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-09-16 (Wed, 16 Sep 2020) Changed paths: M cmk/base/core_config.py M cmk/base/core_nagios.py M cmk/base/modes/check_mk.py M tests/testlib/__init__.py M tests/unit/cmk/base/conftest.py M tests/unit/cmk/base/test_core_config.py M tests/unit/conftest.py Log Message: ----------- Add basic unit test for core config creation Change-Id: Icac7f23a56204c2d69fb7bb6d34a6941bfd66125 Commit: 3c35ba1729d2ded3eb05b2d15844f111ede4bf8f https://github.com/tribe29/checkmk/commit/3c35ba1729d2ded3eb05b2d15844f111e… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-09-16 (Wed, 16 Sep 2020) Changed paths: M cmk/base/automations/check_mk.py M cmk/base/core_factory.py M cmk/base/modes/check_mk.py M tests/unit/cmk/base/test_core_config.py Log Message: ----------- Hand over core name to core object factory Remove artifacts of creating a core binary config in a custom path. Change-Id: I3a63b7803ea332554ba16e08cea32c776e3f51ad Commit: 58abe18b0d9b0a2b669cc0a9494336b81a49bd15 https://github.com/tribe29/checkmk/commit/58abe18b0d9b0a2b669cc0a9494336b81… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-09-16 (Wed, 16 Sep 2020) Changed paths: M cmk/base/core_nagios.py Log Message: ----------- Simplify Nagios config file creation Use our generic file saving logic instead of some local tempfile handling. Change-Id: I49e178960d37fbe12a3233f69670e5e90f962cf8 Commit: 32f931524cf6d150c9f7c371d8f1f93f215df21e https://github.com/tribe29/checkmk/commit/32f931524cf6d150c9f7c371d8f1f93f2… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-09-16 (Wed, 16 Sep 2020) Changed paths: M cmk/base/core_nagios.py M tests/testlib/__init__.py M tests/unit/cmk/base/test_core_nagios.py Log Message: ----------- Separate precompile host check IO from content * The whole IO is moved to HostCheckStore * The content of the precompiled host check files is computed by `_dump_precompiled_hostcheck` and returned as string With the new structure the code is now a bit more testable. Added some basic tests to make use of the separation and to ensure the next refactorings do not break anything fundamentally. Cleanups will follow. Change-Id: I46cbc3a87f7a8433f07b95610222a21ab584b9f7 Commit: e312bd6592c82bcf1617c12ce66dcda02e2d0fa5 https://github.com/tribe29/checkmk/commit/e312bd6592c82bcf1617c12ce66dcda02… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-09-16 (Wed, 16 Sep 2020) Changed paths: M cmk/base/core_nagios.py Log Message: ----------- Simplify precompiled host check write * Use pathlib.Path * Use cmk.utils.store * Remove dead conditional compile after old vs. new source file comparison (The source file is removed at the beginning of the function, the code is never reached) Change-Id: I82d06fe99e07a2a4e76db2624eec02b15a08d58b Commit: 9f92f7755465c1735eb094e7735197fa0ea01ca6 https://github.com/tribe29/checkmk/commit/9f92f7755465c1735eb094e7735197fa0… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-09-16 (Wed, 16 Sep 2020) Changed paths: M cmk/base/core_nagios.py M tests/testlib/__init__.py M tests/unit/cmk/base/test_core_nagios.py Log Message: ----------- Add test to for delayed host check compilation In this mode the compiled file path links to the source file until it is executed for the first time. Then the symlink is replaced with the py-compiled file. Which then optimizes future executions. The non-delayed mode compiles all files during config creation which results in a longer config creation time. Change-Id: I6a5093eed30313bdc8ed0b3eb56caebf1aa2c63e Commit: 53b8bed24f2dd3e3b2f48ce4cb0a3c1b5c89e546 https://github.com/tribe29/checkmk/commit/53b8bed24f2dd3e3b2f48ce4cb0a3c1b5… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-09-16 (Wed, 16 Sep 2020) Changed paths: M cmk/base/core_nagios.py M omd/packages/check_mk/skel/etc/nagios/conf.d/check_mk_templates.cfg M tests/unit/cmk/base/test_core_nagios.py Log Message: ----------- Move Nagios precompiled host checks to helper config directory With this step all parts of the helper configs have been moved to the versioned core helper config directory. The next step will add the update of the helper serial directory. CMK-5444 Change-Id: I84e675593736900356a99985a94f0c88e6c74480 Compare: https://github.com/tribe29/checkmk/compare/5ef260edd564...53b8bed24f2d