[checkmk-commits] Check_MK Git: check_mk: #1969 FIX apc_symmetra: Fix wrong critical state " 0 batteries need replacement"

Module: check_mk Branch: master Commit: 3e5550b900116e1a7ea116e06228dce479cf54e2 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=3e5550b900116e… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Fri Jan 30 14:26:13 2015 +0100 #1969 FIX apc_symmetra: Fix wrong critical state "0 batteries need replacement" --- .werks/1969 | 10 ++++++++++ ChangeLog | 1 + checks/apc_symmetra | 2 +- 3 files changed, 12 insertions(+), 1 deletion(-) diff --git a/.werks/1969 b/.werks/1969 new file mode 100644 index 0000000..534f524 --- /dev/null +++ b/.werks/1969 @@ -0,0 +1,10 @@ +Title: apc_symmetra: Fix wrong critical state "0 batteries need replacement" +Level: 1 +Component: checks +Class: fix +Compatible: compat +State: unknown +Version: 1.2.7i1 +Date: 1422624333 + + diff --git a/ChangeLog b/ChangeLog index 8709a6e..ea1b8ce 100644 --- a/ChangeLog +++ b/ChangeLog @@ -128,6 +128,7 @@ * 1924 FIX: cisco_power: Fixed missing power supplies in case where name is not unique * 1886 FIX: win_printers: Fixed exception in WATO when displaying default parameters * 1887 FIX: Logwatch event console forwarding: Better dealing with logwatch states + * 1969 FIX: apc_symmetra: Fix wrong critical state "0 batteries need replacement" Multisite: * 1758 Improved exception hander: Shows details without additional debug request, added mailto link for error report... diff --git a/checks/apc_symmetra b/checks/apc_symmetra index 752b6f5..4efbd42 100644 --- a/checks/apc_symmetra +++ b/checks/apc_symmetra @@ -121,7 +121,7 @@ def check_apc(item, params, info): if AdvBatteryNumOfBadBattPacks == 1: infotxt = "one battery needs replacement(!)" state = 1 - else: + elif AdvBatteryNumOfBadBattPacks > 1: infotxt = "%i batteries need replacement(!!)" % AdvBatteryNumOfBadBattPacks state = 2 single_states.append( (state, infotxt, None) )