5 Nov
2021
5 Nov
'21
2:02 p.m.
Branch: refs/heads/master
Home: https://github.com/tribe29/checkmk
Commit: 7eafd9e7b4b4749c9728ea74250fe6dd759e4d55
https://github.com/tribe29/checkmk/commit/7eafd9e7b4b4749c9728ea74250fe6dd7…
Author: Lars Michelsen <lm(a)tribe29.com>
Date: 2021-11-05 (Fri, 05 Nov 2021)
Changed paths:
M cmk/gui/cron.py
M cmk/gui/dashboard.py
M cmk/gui/hooks.py
M cmk/gui/metrics.py
M cmk/gui/modules.py
M cmk/gui/notifications.py
M cmk/gui/sidebar.py
M cmk/gui/userdb.py
M cmk/gui/views.py
M cmk/gui/visuals.py
M cmk/gui/wato/__init__.py
M cmk/gui/webapi.py
M tests/unit/cmk/gui/test_gui_hooks.py
M tests/unit/cmk/gui/test_sidebar.py
Log Message:
-----------
Simplify load_plugins() hooks
Previously the load_plugins hooks of all main modules were called on
every request and it was up to the hooks to decide whether or not they
need to do something during every request or just in `force` mode (when
plugins have not been initialized yet or a local plugins has changed).
Now that none of the main modules executed code in non-forced mode
anymore, we could drop the force flag at all. The main module global
state `loaded_with_language` could also be dropped from all the main
modules and centralized as `_plugins_loaded_for` in the cmk.gui.modules
module.
Also cleaned up `call_load_plugins_hooks` a bit more.
Change-Id: I815e229eae706abe5db74d3eba7c6444a242c9d0
Commit: c6783c83b7f5eb16c139f5ae60be31e9fa8892f3
https://github.com/tribe29/checkmk/commit/c6783c83b7f5eb16c139f5ae60be31e9f…
Author: Lars Michelsen <lm(a)tribe29.com>
Date: 2021-11-05 (Fri, 05 Nov 2021)
Changed paths:
M cmk/gui/wsgi/applications/checkmk.py
Log Message:
-----------
Move load_plugins() hook calls out of request context
This step is done to ensure that the load_plugins hooks are independent
of the RequestContext and Config.
Change-Id: Ic510a3c50aa82eca9b6e35d4226f891ac5e0416a
Commit: 6e479e6df81e167f3cb6f1c9f2dba5ce4a3ccec1
https://github.com/tribe29/checkmk/commit/6e479e6df81e167f3cb6f1c9f2dba5ce4…
Author: Lars Michelsen <lm(a)tribe29.com>
Date: 2021-11-05 (Fri, 05 Nov 2021)
Changed paths:
M cmk/utils/paths.py
M tests/testlib/__init__.py
A tests/unit/cmk/gui/test_modules.py
M tests/unit/cmk/utils/test_paths.py
Log Message:
-----------
Add plugin loading tests
* Test loading legacy plugins of the different main modules
* Test that standard module based plugins are loaded of all main
modules. We don't test for the individual plugins that are loaded
since we only want to ensure that the loading mechanism is working.
Change-Id: Icef47015bf664e4b8faf6005af7d9cd2b1c3abf4
Commit: d39b4ddf453b605035acc439d7be58ff87359b58
https://github.com/tribe29/checkmk/commit/d39b4ddf453b605035acc439d7be58ff8…
Author: Lars Michelsen <lm(a)tribe29.com>
Date: 2021-11-05 (Fri, 05 Nov 2021)
Changed paths:
M cmk/gui/wsgi/applications/checkmk.py
M web/app/index.wsgi
Log Message:
-----------
Load plugins during app initialization
Since 1.6 we require no localized strings to be on module scope. This
enables us to load the plugins during application initialization and not
later during each request.
Change-Id: I323e024bdcfb9b8e4f6eb4d55a65f7e15ea2862a
Commit: 448803572d52878113b351da38d74cd80896b4be
https://github.com/tribe29/checkmk/commit/448803572d52878113b351da38d74cd80…
Author: Lars Michelsen <lm(a)tribe29.com>
Date: 2021-11-05 (Fri, 05 Nov 2021)
Changed paths:
M web/app/.f12
Log Message:
-----------
Fix wrong .f12 site detection
Change-Id: I6de2cce1dfd2aaa74af3f77c5c8c54fbe430de9e
Commit: 7ad4afe2b846e8ac89a8a8294824a81f0a56bd7a
https://github.com/tribe29/checkmk/commit/7ad4afe2b846e8ac89a8a8294824a81f0…
Author: Lars Michelsen <lm(a)tribe29.com>
Date: 2021-11-05 (Fri, 05 Nov 2021)
Changed paths:
M cmk/gui/wsgi/applications/utils.py
M cmk/gui/wsgi/profiling.py
M web/app/index.wsgi
Log Message:
-----------
Initialize GUI logging before plugin loading
This enables us to see the debug log entries we expect
during the early application initialization phase.
Change-Id: I28e757f776f02e0e697518b0e065544fb7c16cf4
Commit: da47ef770d7ea5f290c046765da866ab52505ae1
https://github.com/tribe29/checkmk/commit/da47ef770d7ea5f290c046765da866ab5…
Author: Lars Michelsen <lm(a)tribe29.com>
Date: 2021-11-05 (Fri, 05 Nov 2021)
Changed paths:
M cmk/gui/pagetypes.py
M tests/unit/cmk/gui/conftest.py
M tests/unit/cmk/gui/plugins/metrics/test_metrics_utils.py
M tests/unit/cmk/gui/plugins/sidebar/test_snapins.py
M tests/unit/cmk/gui/plugins/sidebar/test_wato.py
M tests/unit/cmk/gui/plugins/views/test_painters.py
M tests/unit/cmk/gui/plugins/visuals/test_filters.py
M tests/unit/cmk/gui/plugins/wato/utils/test_main_menu.py
M tests/unit/cmk/gui/test_gui_config.py
M tests/unit/cmk/gui/test_pages.py
M tests/unit/cmk/gui/test_sidebar.py
M tests/unit/cmk/gui/test_views.py
M tests/unit/cmk/gui/test_visuals.py
M tests/unit/cmk/gui/watolib/test_activate_changes.py
M tests/unit/cmk/gui/watolib/test_config_sync.py
M tests/unit/cmk/gui/watolib/test_hosts_and_folders.py
M tests/unit/cmk/gui/watolib/test_main_menu_watolib.py
M tests/unit/cmk/gui/watolib/test_rulespecs.py
M tests/unit/cmk/gui/watolib/test_watolib.py
Log Message:
-----------
Align load_plugins fixture with real world
Previously only some tests were explicitly loading the GUI plugins.
Since the modules were loaded into the python and application global
structures, this is error prone. Subsequent tests which rely on the
plugins but not use the load_plugins fixture were working as long as the
previous test was executed before. But when the second test was executed
alone, this lead to a failing test.
To solve this situation the load_plugins fixture is now a session wide
fixture and automatically loaded for all GUI tests. This is less error
prone and also reflects the real world of the GUI code: The plugins are
loaded early in application initialization and available in the moment
the application code is executed.
Change-Id: I752b6bb6123a923facf9623421aee15837a4616d
Compare: https://github.com/tribe29/checkmk/compare/34867b741363...da47ef770d7e