[checkmk-commits] [tribe29/checkmk] 8877ec: Refactor use combined graph spec as general argument

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 8877ec51dc9c4c8387a7ddb92c7673114bba0d0c https://github.com/tribe29/checkmk/commit/8877ec51dc9c4c8387a7ddb92c7673114… Author: Óscar Nájera <oscar.najera(a)tribe29.com> Date: 2020-08-18 (Tue, 18 Aug 2020) Changed paths: M cmk/gui/plugins/webapi/grafana.py Log Message: ----------- Refactor use combined graph spec as general argument - Calls to find datasource are deduplicated - data_source_registry has type ABCDataSource, cast is needed to recognize which child class is in use. Change-Id: I8c9c298ecbb62eb216df044a2c21dd9f3cf74fe9 Commit: a31595b4dd0f505a3a15e29f174208dc359c72d9 https://github.com/tribe29/checkmk/commit/a31595b4dd0f505a3a15e29f174208dc3… Author: Óscar Nájera <oscar.najera(a)tribe29.com> Date: 2020-08-18 (Tue, 18 Aug 2020) Changed paths: M cmk/gui/plugins/metrics/rrd_fetch.py M cmk/gui/plugins/metrics/timeseries.py Log Message: ----------- CustomGraphs allows all combined graph aggregations A single metric recipe can now have a multi-line output and thus produce stacked or many lines metrics. - Driving change is in graphs.py to isolate how metric recipes are resolved - Remove the graphed objects dependency on combined title generator, use information from generated template - The metric specifications can be then used to resolve the (rrd) expression for fetching data and later on when timeseries.py evaluates values into the curves - timeseries.py can now treat all aggregations of by fundamentally testing if evaluated expression is an list of tuples with many elements or a single timeseries by default - Because the metric resolution happens now later on the pipeline (rrd_fetch), there is no need to reverse translate the combined specification and thus is just piped. TODO Harmonize styling. For the moment there is conflicting behavior between customgraph color/line style and the Combined graph recipe generator which already provides styling. Change-Id: I93ca4efa30658924058488735a484fef1fd0f05c Compare: https://github.com/tribe29/checkmk/compare/e940c59850c5...a31595b4dd0f