[checkmk-commits] [tribe29/checkmk] a0502f: Introduce new mechanism for confirm dialogs

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: a0502f0d2d6cdcd1cab0df08cd69b9f6ca320ce1 https://github.com/tribe29/checkmk/commit/a0502f0d2d6cdcd1cab0df08cd69b9f6c… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-11-05 (Thu, 05 Nov 2020) Changed paths: M cmk/gui/htmllib.py M cmk/gui/wato/pages/host_rename.py M web/htdocs/js/modules/dashboard.js M web/htdocs/js/modules/forms.js M web/htdocs/js/modules/page_menu.js Log Message: ----------- Introduce new mechanism for confirm dialogs Form resubmission issues in WATO have been fixed for regular forms recently. This problem is currently unsolved for forms involving confirm dialogs. This commit introduces a solution for that issue by replacing the existing confirm dialog logic with a Javascript based confirm dialog. This has the advantage that the confirm message is raised before the form is submitted to the server. It really reduces the complexity of the confirm dialog logic and will make it possible to simplify our Python code. Some drawbacks have already identified: Previously the confirm dialogs were rendered by the Python code. This made it possible to a) perform some logic on the Python side to get more information for the confirm message. b) perform some of our server side validations before displaying the confirm dialog. After a quick look at some call sites it looks like we can live with it. Let's go with this solution and solve possible problems if we stumble upon it. CMK-6214 Change-Id: Idb99369a1cdb3f857e12ceba5e7285a7705620f9 Commit: b5973d3839f0b4da588d296d13e855b80393a231 https://github.com/tribe29/checkmk/commit/b5973d3839f0b4da588d296d13e855b80… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-11-05 (Thu, 05 Nov 2020) Changed paths: M cmk/gui/htmllib.py M cmk/gui/wato/pages/sites.py M web/htdocs/js/modules/forms.js Log Message: ----------- Add option to use new confirm dialog for action icons CMK-6214 Change-Id: I1b95b8b3b4e44e7928d9565e9796df10b3333e7d Commit: f61e250b04e898d00229020eb2fb6b109b032369 https://github.com/tribe29/checkmk/commit/f61e250b04e898d00229020eb2fb6b109… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-11-05 (Thu, 05 Nov 2020) Changed paths: M cmk/gui/wato/mkeventd.py M cmk/gui/wato/pages/global_settings.py M cmk/gui/wato/pages/sites.py Log Message: ----------- Remove dead code from global settings list dialog The only settings that are set directly on the list dialog are the ON/OFF toggles. And these did not have a confirm dialog before. For this reason we can completely remove the confirm logic from these modes. Change-Id: I2a2c42deb956d15bcafff33dd4dd19bc67a29c13 Commit: e2a6060593b2902f64190b8c34530bf7a6fbcf4f https://github.com/tribe29/checkmk/commit/e2a6060593b2902f64190b8c34530bf7a… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-11-05 (Thu, 05 Nov 2020) Changed paths: M cmk/gui/htmllib.py M cmk/gui/page_menu.py M cmk/gui/wato/pages/global_settings.py M web/htdocs/js/modules/page_menu.js Log Message: ----------- Add confirmed form submit helper for page menu submit links In case we have forms with multiple different actions, where some of the actions need a confirmation and some not, we need to have an individual handling for each button. This helper function supports this case by providing an individuall helper function for all page menu entries of this kind. CMK-6214 Change-Id: I7ea68ac51700cd4e8e2ff71adbbe734a38b296c3 Compare: https://github.com/tribe29/checkmk/compare/4553e3bd164e...e2a6060593b2